linux-kernel - Re: [PATCH v7 0/2] Microchip Polarfire FPGA manager

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <038b9664-2f70-7c32-6565-fbd0f3da789d@conchuod.ie>
Date:   Tue, 22 Mar 2022 19:38:57 +0000
From:   Conor Dooley <mail@...chuod.ie>
To:     Ivan Bornyakov <i.bornyakov@...rotek.ru>
Cc:     mdf@...nel.org, hao.wu@...el.com, yilun.xu@...el.com,
        trix@...hat.com, conor.dooley@...rochip.com, robh+dt@...nel.org,
        system@...rotek.ru, linux-kernel@...r.kernel.org,
        linux-fpga@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v7 0/2] Microchip Polarfire FPGA manager

On 22/03/2022 04:32, Ivan Bornyakov wrote:
> Add support to the FPGA manager for programming Microchip Polarfire
> FPGAs over slave SPI interface with .dat formatted bitsream image.
> 

Finally had a board appear on my desk today with its spi programming
interface exposed, so should be able to test this at last.

Thanks,
Conor.

> Changelog:
>    v1 -> v2: fix printk formating
>    v2 -> v3:
>     * replace "microsemi" with "microchip"
>     * replace prefix "microsemi_fpga_" with "mpf_"
>     * more sensible .compatible and .name strings
>     * remove unused defines STATUS_SPI_VIOLATION and STATUS_SPI_ERROR
>    v3 -> v4: fix unused variable warning
>      Put 'mpf_of_ids' definition under conditional compilation, so it
>      would not hang unused if CONFIG_OF is not enabled.
>    v4 -> v5:
>     * prefix defines with MPF_
>     * mdelay() -> usleep_range()
>     * formatting fixes
>     * add DT bindings doc
>     * rework fpga_manager_ops.write() to fpga_manager_ops.write_sg()
>       We can't parse image header in write_init() because image header
>       size is not known beforehand. Thus parsing need to be done in
>       fpga_manager_ops.write() callback, but fpga_manager_ops.write()
>       also need to be reenterable. On the other hand,
>       fpga_manager_ops.write_sg() is called once. Thus, rework usage of
>       write() callback to write_sg().
>    v5 -> v6: fix patch applying
>       I forgot to clean up unrelated local changes which lead to error on
>       patch 0001-fpga-microchip-spi-add-Microchip-MPF-FPGA-manager.patch
>       applying on vanilla kernel.
>    v6 ->v7: fix binding doc to pass dt_binding_check
> 
> Ivan Bornyakov (2):
>    fpga: microchip-spi: add Microchip MPF FPGA manager
>    dt-bindings: fpga: add binding doc for microchip-spi fpga mgr
> 
>   .../fpga/microchip,mpf-spi-fpga-mgr.yaml      |  44 ++
>   drivers/fpga/Kconfig                          |  10 +
>   drivers/fpga/Makefile                         |   1 +
>   drivers/fpga/microchip-spi.c                  | 448 ++++++++++++++++++
>   4 files changed, 503 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/fpga/microchip,mpf-spi-fpga-mgr.yaml
>   create mode 100644 drivers/fpga/microchip-spi.c
>