linux-kernel - Re: [v3 13/13] docs: iio: add documentation for BNO055 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220322203216.0000141f@Huawei.com>
Date:   Tue, 22 Mar 2022 20:32:16 +0000
From:   Jonathan Cameron <Jonathan.Cameron@...wei.com>
To:     Andrea Merello <andrea.merello@...il.com>
CC:     Jonathan Cameron <jic23@...nel.org>,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        linux-iio <linux-iio@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        "Rob Herring" <robh+dt@...nel.org>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Matt Ranostay <matt.ranostay@...sulko.com>,
        Alexandru Ardelean <ardeleanalex@...il.com>,
        Jacopo Mondi <jacopo@...ndi.org>,
        Andrea Merello <andrea.merello@....it>
Subject: Re: [v3 13/13] docs: iio: add documentation for BNO055 driver

On Tue, 22 Mar 2022 11:30:12 +0100
Andrea Merello <andrea.merello@...il.com> wrote:

> [...]
> 
> > > +IIO attributes for unavailable measurements (e.g. Euler angles when fusion
> > > +mode is disabled) just read zero.  
> >
> > Hmm. Should probably return -EBUSY as 0 could be a valid value.
> >  
> 
> While it seems reasonable,  that can be easily done while reading from
> sysfs, but how do we handle this when reading from buffer?
> Right now both sysfs and buffer read zero from unused chans, which it
> is at least consistent..

Can't we refuse to start the buffer if we have a channel enabled that
makes no sense in the current mode?

If seems very odd to allow capture of 'nothing'.

Jonathan