linux-kernel - Re: [PATCH RESEND 1/2] perf string: Add strcmp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yjo+MdJaauraN6eX@kernel.org>
Date:   Tue, 22 Mar 2022 18:22:57 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Wei Li <liwei391@...wei.com>
Cc:     mark.rutland@....com, alexander.shishkin@...ux.intel.com,
        jolsa@...hat.com, namhyung@...nel.org,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
        rui.xiang@...wei.com, guohanjun@...wei.com
Subject: Re: [PATCH RESEND 1/2] perf string: Add strcmp_prefix()

Em Fri, Mar 18, 2022 at 05:22:44PM +0800, Wei Li escreveu:
> Add a helper to check whether a string has the given prefix.
> This function is stolen from fs/xattr.c

Can't you use strstarts()? See tools/include/linux/string.h.

- Arnaldo
 
> Signed-off-by: Wei Li <liwei391@...wei.com>
> ---
>  tools/perf/util/string.c  | 17 +++++++++++++++++
>  tools/perf/util/string2.h |  1 +
>  2 files changed, 18 insertions(+)
> 
> diff --git a/tools/perf/util/string.c b/tools/perf/util/string.c
> index f6d90cdd9225..0ed3e2d0b70f 100644
> --- a/tools/perf/util/string.c
> +++ b/tools/perf/util/string.c
> @@ -209,6 +209,23 @@ int strtailcmp(const char *s1, const char *s2)
>  	return 0;
>  }
>  
> +/**
> + * strcmp_prefix - check string for given prefix
> + * @str: the target string to check
> + * @prefix: the given prefix to match
> + *
> + * Return the rest string in @str if @str has the given @prefix, return NULL
> + * otherwise.
> + */
> +const char *strcmp_prefix(const char *str, const char *prefix)
> +{
> +	while (*prefix && *str == *prefix) {
> +		str++;
> +		prefix++;
> +	}
> +	return *prefix ? NULL : str;
> +}
> +
>  char *asprintf_expr_inout_ints(const char *var, bool in, size_t nints, int *ints)
>  {
>  	/*
> diff --git a/tools/perf/util/string2.h b/tools/perf/util/string2.h
> index 56c30fef9682..58929ad928f7 100644
> --- a/tools/perf/util/string2.h
> +++ b/tools/perf/util/string2.h
> @@ -20,6 +20,7 @@ static inline bool strisglob(const char *str)
>  	return strpbrk(str, "*?[") != NULL;
>  }
>  int strtailcmp(const char *s1, const char *s2);
> +const char *strcmp_prefix(const char *str, const char *prefix);
>  
>  char *asprintf_expr_inout_ints(const char *var, bool in, size_t nints, int *ints);
>  
> -- 
> 2.25.1

-- 

- Arnaldo