linux-kernel - Re: [PATCH] Bluetooth: mt7921s: Fix a wrong judgment in btmtksdio_get_codec_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220322225700.16125-1-miles.chen@mediatek.com>
Date:   Wed, 23 Mar 2022 06:57:00 +0800
From:   Miles Chen <miles.chen@...iatek.com>
To:     <liaoyu15@...wei.com>
CC:     <linux-kernel@...r.kernel.org>, <liwei391@...wei.com>,
        <marcel@...tmann.org>, <yake.yang@...iatek.com>
Subject: Re: [PATCH] Bluetooth: mt7921s: Fix a wrong judgment in btmtksdio_get_codec_config_data()

Hi Yu,

>Since ven_data is a double pointer, it should be *ven_data here.
>
>Fixes: f41b91fa1783 ("Bluetooth: mt7921s: Add .btmtk_get_codec_config_data")
>Signed-off-by: Yu Liao <liaoyu15@...wei.com>
>---
> drivers/bluetooth/btmtksdio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/bluetooth/btmtksdio.c b/drivers/bluetooth/btmtksdio.c
>index f3dc5881fff7..b6d77e04240c 100644
>--- a/drivers/bluetooth/btmtksdio.c
>+++ b/drivers/bluetooth/btmtksdio.c
>@@ -961,7 +961,7 @@ static int btmtksdio_get_codec_config_data(struct hci_dev *hdev,
> 	}
> 
> 	*ven_data = kmalloc(sizeof(__u8), GFP_KERNEL);
>-	if (!ven_data) {
>+	if (!*ven_data) {
> 		err = -ENOMEM;
> 		goto error;
> 	}

Thanks for fixing this.

Reviewed-by: Miles Chen <miles.chen@...iatek.com>