linux-kernel - Re: [PATCH] dt-bindings: virtio: mmio: add optional virtio,wakeup property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220322061956.GA1441@mingxue-gv.qualcomm.com>
Date:   Tue, 22 Mar 2022 14:19:56 +0800
From:   Minghao Xue <quic_mingxue@...cinc.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
CC:     Jean-Philippe Brucker <jean-philippe@...aro.org>, <mst@...hat.com>,
        <jasowang@...hat.com>, <quic_ztu@...cinc.com>,
        <robh+dt@...nel.org>, <virtualization@...ts.linux-foundation.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dt-bindings: virtio: mmio: add optional virtio,wakeup
 property

Hi Krzysztof,

Thanks for your comment. First of all, which "generic wakeup-source
property" do you mean? Could you give an example? I find "wakeup-source"
property in several binding files. Are you pointing to this? As my
understanding, there is no standard naming rule about the property of
each driver right? Currently, there's no virtio-mmio driver using this.
Anyway, I can modify my patch, if you prefer "wakeup-source".

Regards,
Minghao

On Fri, Mar 18, 2022 at 02:40:29PM +0100, Krzysztof Kozlowski wrote:
> On 18/03/2022 03:10, Minghao Xue wrote:
> > Hi Jean and folks,
> > This is just an optional flag which could be used on an embedded system.
> > For example, if we want to use an virtio-input device as a virtual power
> > key to wake up the virtual machine, we can set this flag in the device
> > tree.
> > Currently, virio-mmio driver does not implement suspend/resume
> > callback(maybe no need). So we want to check this flag and call
> > enable_irq_wake()  accordingly in vm_find_vqs().
> 
> There is a generic wakeup-source property. How is this one different
> that you need a separate one?
> 
> 
> Best regards,
> Krzysztof