linux-kernel - Re: [PATCH 6/7] perf/x86/amd/core: Add PerfMonV2 overflow handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4bc9b537-f0de-5b75-5418-61c1d6dca849@gmail.com>
Date:   Tue, 22 Mar 2022 15:06:49 +0800
From:   Like Xu <like.xu.linux@...il.com>
To:     Sandipan Das <sandipan.das@....com>
Cc:     peterz@...radead.org, bp@...en8.de, dave.hansen@...ux.intel.com,
        acme@...nel.org, mark.rutland@....com,
        alexander.shishkin@...ux.intel.com, namhyung@...nel.org,
        jolsa@...nel.org, tglx@...utronix.de, mingo@...hat.com,
        pbonzini@...hat.com, jmattson@...gle.com, eranian@...gle.com,
        ananth.narayan@....com, ravi.bangoria@....com,
        santosh.shukla@....com,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-perf-users@...r.kernel.org, x86@...nel.org
Subject: Re: [PATCH 6/7] perf/x86/amd/core: Add PerfMonV2 overflow handling

On 17/3/2022 2:28 pm, Sandipan Das wrote:
> +		val = x86_perf_event_update(event);

The variable 'val' set but not used.

> +		mask = BIT_ULL(idx);
> +
> +		if (!(status & mask))

Needed here ?

> +			continue;