linux-kernel - Re: [GIT PULL] scheduler updates for v5.18

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 22 Mar 2022 08:54:53 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     Nathan Chancellor <nathan@...nel.org>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-kernel@...r.kernel.org,
        Peter Zijlstra <peterz@...radead.org>,
        Juri Lelli <juri.lelli@...hat.com>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
        Daniel Bristot de Oliveira <bristot@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Borislav Petkov <bp@...en8.de>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [GIT PULL] scheduler updates for v5.18


* Nathan Chancellor <nathan@...nel.org> wrote:

> Hi Ingo,
> 
> On Mon, Mar 21, 2022 at 11:54:09AM +0100, Ingo Molnar wrote:
> > Ingo Molnar (17):
> >       sched/headers: Fix header to build standalone: <linux/sched_clock.h>
> >       sched/headers: Add header guard to kernel/sched/sched.h
> >       sched/headers: Add header guard to kernel/sched/stats.h and kernel/sched/autogroup.h
> >       sched/headers: sched/clock: Mark all functions 'notrace', remove CC_FLAGS_FTRACE build asymmetry
> >       sched/headers: Add initial new headers as identity mappings
> >       sched/headers: Fix comment typo in kernel/sched/cpudeadline.c
> >       sched/headers: Make the <linux/sched/deadline.h> header build standalone
> >       sched/headers: Introduce kernel/sched/build_utility.c and build multiple .c files there
> >       sched/headers: Introduce kernel/sched/build_policy.c and build multiple .c files there
> >       sched/headers: Standardize kernel/sched/sched.h header dependencies
> >       sched/headers: Reorganize, clean up and optimize kernel/sched/core.c dependencies
> >       sched/headers: Reorganize, clean up and optimize kernel/sched/fair.c dependencies
> >       sched/headers: Reorganize, clean up and optimize kernel/sched/build_policy.c dependencies
> >       sched/headers: Reorganize, clean up and optimize kernel/sched/build_utility.c dependencies
> >       sched/headers: Reorganize, clean up and optimize kernel/sched/sched.h dependencies
> >       sched/headers: Only include <linux/entry-common.h> when CONFIG_GENERIC_ENTRY=y
> >       headers/prep: Fix header to build standalone: <linux/psi.h>
> 
> This series regresses ARCH=arm allmodconfig:
> 
> $ make -skj"$(nproc)" ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- mrproper allmodconfig kernel/sched/
> In file included from kernel/sched/fair.c:52:
> kernel/sched/sched.h:87:11: fatal error: asm/paravirt_api_clock.h: No such file or directory
>    87 | # include <asm/paravirt_api_clock.h>
>       |           ^~~~~~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.
> make[3]: *** [scripts/Makefile.build:288: kernel/sched/fair.o] Error 1
> In file included from kernel/sched/core.c:81:
> kernel/sched/sched.h:87:11: fatal error: asm/paravirt_api_clock.h: No such file or directory
>    87 | # include <asm/paravirt_api_clock.h>
>       |           ^~~~~~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.
> make[3]: *** [scripts/Makefile.build:288: kernel/sched/core.o] Error 1
> In file included from kernel/sched/build_policy.c:33:
> kernel/sched/sched.h:87:11: fatal error: asm/paravirt_api_clock.h: No such file or directory
>    87 | # include <asm/paravirt_api_clock.h>
>       |           ^~~~~~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.
> make[3]: *** [scripts/Makefile.build:288: kernel/sched/build_policy.o] Error 1
> In file included from kernel/sched/build_utility.c:52:
> kernel/sched/sched.h:87:11: fatal error: asm/paravirt_api_clock.h: No such file or directory
>    87 | # include <asm/paravirt_api_clock.h>
>       |           ^~~~~~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.
> make[3]: *** [scripts/Makefile.build:288: kernel/sched/build_utility.o] Error 1
> make[3]: Target '__build' not remade because of errors.
> make[2]: *** [scripts/Makefile.build:550: kernel/sched] Error 2
> 
> Randy Dunlap has sent a patch that fixes it, which I just reviewed:
> 
> https://lore.kernel.org/r/20220316204146.14000-1-rdunlap@infradead.org/

Applied, thanks Nathan!

> It would be nice if this could be taken with the pull (or submitted with
> the pull in a v2 as I see Qian's comment) to avoid regressing the build.

Will do.

Thanks,

	Ingo