linux-kernel - Re: [PATCH v11 5/5] usb: dwc3: qcom: Keep power domain on to retain controller status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <982fdf9c-58a9-9a67-15e9-ff47b6ff1c93@quicinc.com>
Date:   Tue, 22 Mar 2022 14:48:32 +0530
From:   "Sandeep Maheswaram (Temp)" <quic_c_sanm@...cinc.com>
To:     Pavan Kondeti <quic_pkondeti@...cinc.com>
CC:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Felipe Balbi <balbi@...nel.org>,
        Stephen Boyd <swboyd@...omium.org>,
        Doug Anderson <dianders@...omium.org>,
        "Matthias Kaehlcke" <mka@...omium.org>,
        Mathias Nyman <mathias.nyman@...el.com>,
        <linux-arm-msm@...r.kernel.org>, <linux-usb@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <quic_ppratap@...cinc.com>
Subject: Re: [PATCH v11 5/5] usb: dwc3: qcom: Keep power domain on to retain
 controller status

Hi Pavan,

On 3/22/2022 2:07 PM, Pavan Kondeti wrote:
> Hi Sandeep,
>
> On Tue, Mar 22, 2022 at 12:37:56PM +0530, Sandeep Maheswaram wrote:
>> Keep the power domain on in order to retail controller status and
>> to support wakeup from devices.
>>
> %s/retail/retain
>
> retain the controller status so that remote wakeup / device connect /
> device disconnect events can be detected during suspend.
Will correct in next version.
>
>> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@...cinc.com>
>> ---
>>   drivers/usb/dwc3/dwc3-qcom.c | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c
>> index 9804a19..35087cf 100644
>> --- a/drivers/usb/dwc3/dwc3-qcom.c
>> +++ b/drivers/usb/dwc3/dwc3-qcom.c
>> @@ -17,6 +17,7 @@
>>   #include <linux/of_platform.h>
>>   #include <linux/platform_device.h>
>>   #include <linux/phy/phy.h>
>> +#include <linux/pm_domain.h>
>>   #include <linux/usb/of.h>
>>   #include <linux/reset.h>
>>   #include <linux/iopoll.h>
>> @@ -724,6 +725,7 @@ static int dwc3_qcom_probe(struct platform_device *pdev)
>>   	struct resource		*res, *parent_res = NULL;
>>   	int			ret, i;
>>   	bool			ignore_pipe_clk;
>> +	struct generic_pm_domain *genpd;
>>   
>>   	qcom = devm_kzalloc(&pdev->dev, sizeof(*qcom), GFP_KERNEL);
>>   	if (!qcom)
>> @@ -732,6 +734,8 @@ static int dwc3_qcom_probe(struct platform_device *pdev)
>>   	platform_set_drvdata(pdev, qcom);
>>   	qcom->dev = &pdev->dev;
>>   
>> +	genpd = pd_to_genpd(qcom->dev->pm_domain);
>> +
>>   	if (has_acpi_companion(dev)) {
>>   		qcom->acpi_pdata = acpi_device_get_match_data(dev);
>>   		if (!qcom->acpi_pdata) {
>> @@ -839,6 +843,8 @@ static int dwc3_qcom_probe(struct platform_device *pdev)
>>   	if (ret)
>>   		goto interconnect_exit;
>>   
>> +	genpd->flags |= GENPD_FLAG_ALWAYS_ON;
>> +
>>   	device_init_wakeup(&pdev->dev, 1);
>>   	qcom->is_suspended = false;
>>   	pm_runtime_set_active(dev);
>> -- 
>> 2.7.4
>>
> Thanks,
> Pavan