linux-kernel - Re: [PATCH 1/2] x86/chacha20: Avoid spurious jumps to other functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6250f5f254f08bf767c052fbe0b5e281cafea2cc.camel@strongswan.org>
Date:   Tue, 22 Mar 2022 13:18:57 +0100
From:   Martin Willi <martin@...ongswan.org>
To:     Peter Zijlstra <peterz@...radead.org>, x86@...nel.org
Cc:     linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
        ebiggers@...gle.com, herbert@...dor.apana.org.au, Jason@...c4.com,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH 1/2] x86/chacha20: Avoid spurious jumps to other
 functions


> The chacha_Nblock_xor_avx512vl() functions all have their own,
> identical, .LdoneN label, however in one particular spot {2,4} jump
> to the 8 version instead of their own. [...]
> 
> Make each function consistently use its own done label.

Reviewed-by: Martin Willi <martin@...ongswan.org>