linux-kernel - Re: [PATCH v18 14/18] s390/vfio-ap: sysfs attribute to display the guest's matrix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <381b7144-3e60-a825-06fb-ea15ecb4c365@linux.ibm.com>
Date:   Tue, 22 Mar 2022 09:41:22 -0400
From:   Tony Krowiak <akrowiak@...ux.ibm.com>
To:     jjherne@...ux.ibm.com, linux-s390@...r.kernel.org,
        linux-kernel@...r.kernel.org, kvm@...r.kernel.org
Cc:     freude@...ux.ibm.com, borntraeger@...ibm.com, cohuck@...hat.com,
        mjrosato@...ux.ibm.com, pasic@...ux.ibm.com,
        alex.williamson@...hat.com, kwankhede@...dia.com,
        fiuczy@...ux.ibm.com
Subject: Re: [PATCH v18 14/18] s390/vfio-ap: sysfs attribute to display the
 guest's matrix



On 3/22/22 09:22, Jason J. Herne wrote:
> On 2/14/22 19:50, Tony Krowiak wrote:
>> The matrix of adapters and domains configured in a guest's APCB may
>> differ from the matrix of adapters and domains assigned to the matrix 
>> mdev,
>> so this patch introduces a sysfs attribute to display the matrix of
>> adapters and domains that are or will be assigned to the APCB of a guest
>> that is or will be using the matrix mdev. For a matrix mdev denoted by
>> $uuid, the guest matrix can be displayed as follows:
>>
>>     cat /sys/devices/vfio_ap/matrix/$uuid/guest_matrix
> My OCD wants you to name this matrix_guest instead of guest_matrix. 
> Simply
> because then "matrix" and "matrix_guest" will be grouped together when 
> doing
> an ls on the parent directory. As a system admin, its the little 
> things that
> make the difference :) Please consider... though I won't withhold an 
> R-b for
> it.

I am going to leave it as guest_matrix for two reasons:
1. To me, the name matrix_guest reads like the guest belongs to the 
matrix rather
     than the matrix belonging to the guest.
2. Changing it will require changes to all of the automated test cases 
that check
     sysfs to determine whether the attribute is present and I don't 
think the juice
     is worth the squeeze.

>
> Reviewed-by: Jason J. Herne <jjherne@...ux.ibm.com>
>