linux-kernel - Re: An announcement for kernel-global workqueue users.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5ha6dixb9z.wl-tiwai@suse.de>
Date:   Tue, 22 Mar 2022 16:22:16 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
Cc:     LKML <linux-kernel@...r.kernel.org>, Tejun Heo <tj@...nel.org>,
        Lai Jiangshan <jiangshanlai@...il.com>
Subject: Re: An announcement for kernel-global workqueue users.

On Mon, 21 Mar 2022 02:24:23 +0100,
Tetsuo Handa wrote:
> 
> Hello.
> 
> The Linux kernel provides kernel-global WQs (namely, system_wq, system_highpri_wq,
> system_long_wq, system_unbound_wq, system_freezable_wq, system_power_efficient_wq
> and system_freezable_power_efficient_wq). But since attempt to flush kernel-global
> WQs has possibility of deadlock, Tejun Heo thinks that we should stop calling
> flush_scheduled_work() and flush_workqueue(system_*). Such callers as of Linux 5.17
> are listed below.
> 
> ----------
> $ git grep -nF 'flush_scheduled_work()'
(snip)
> sound/soc/intel/atom/sst/sst.c:363:     flush_scheduled_work();

At least this one looks superfluous, the call can be simply dropped.
I'm going to submit a fix patch.


thanks,

Takashi