linux-kernel - Re: [PATCH] net: l2tp: Fix duplicate included trace.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220322221418.55f6a665@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 22 Mar 2022 22:14:18 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Haowen Bai <baihaowen@...zu.com>
Cc:     <davem@...emloft.net>, <pabeni@...hat.com>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: l2tp: Fix duplicate included trace.h

On Wed, 23 Mar 2022 11:38:25 +0800 Haowen Bai wrote:
> Clean up the following includecheck warning:
> 
> net/l2tp/l2tp_core.c: trace.h is included more than once.
> 
> No functional change.

This one doesn't build either.

You must validate your patches to the best of your ability.
If the best of your ability does not include firing up 
a compiler - that will be a problem.