linux-kernel - Re: [PATCH] platform/x86: barco-p50-gpio: Fix duplicate included inux/io.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87ils5f817.fsf@dell.be.48ers.dk>
Date:   Wed, 23 Mar 2022 08:21:56 +0100
From:   Peter Korsgaard <peter@...sgaard.com>
To:     Haowen Bai <baihaowen@...zu.com>
Cc:     <santoshkumar.yadav@...co.com>, <peter.korsgaard@...co.com>,
        <hdegoede@...hat.com>, <markgross@...nel.org>,
        <platform-driver-x86@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: barco-p50-gpio: Fix duplicate included
 inux/io.h

>>>>> "Haowen" == Haowen Bai <baihaowen@...zu.com> writes:

 > Clean up the following includecheck warning:
 > drivers/platform/x86/barco-p50-gpio.c: linux/io.h is included more than once.

 > No functional change.

 > Signed-off-by: Haowen Bai <baihaowen@...zu.com>
 > ---
 >  drivers/platform/x86/barco-p50-gpio.c | 1 -
 >  1 file changed, 1 deletion(-)

 > diff --git a/drivers/platform/x86/barco-p50-gpio.c b/drivers/platform/x86/barco-p50-gpio.c
 > index f5c72e3..bb8ed8e 100644
 > --- a/drivers/platform/x86/barco-p50-gpio.c
 > +++ b/drivers/platform/x86/barco-p50-gpio.c
 > @@ -14,7 +14,6 @@
 >  #include <linux/delay.h>
 >  #include <linux/dmi.h>
 >  #include <linux/err.h>
 > -#include <linux/io.h>

It would be nicer to drop the io.h include higher up to keep the
(almost) alphabetical ordering.

Other than that:

Acked-by: Peter Korsgaard <peter.korsgaard@...co.com>

-- 
Bye, Peter Korsgaard