linux-kernel - Re: [PATCH] ata: libata-core: fix "it's" typos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+ToGPEAhWDwFLNHqXvtuumvdLQb=kzme7fdrgBfb4zojVvDNQ@mail.gmail.com>
Date:   Wed, 23 Mar 2022 04:24:16 -0300
From:   Diego Viola <diego.viola@...il.com>
To:     Damien Le Moal <damien.lemoal@...nsource.wdc.com>
Cc:     linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
        corbet@....net
Subject: Re: [PATCH] ata: libata-core: fix "it's" typos

On Wed, Mar 23, 2022 at 2:53 AM Damien Le Moal
<damien.lemoal@...nsource.wdc.com> wrote:
>
> On 3/23/22 14:52, Diego Viola wrote:
> > On Wed, Mar 23, 2022 at 2:45 AM Damien Le Moal
> > <damien.lemoal@...nsource.wdc.com> wrote:
> >>
> >> On 3/23/22 14:40, Diego Viola wrote:
> >>> Use the contraction "it's" instead of the possessive form "its".
> >>
> >> Well, while at it, let's use proper formal written English, so:
> >> s/it's/it is
> >> s/isn't/is not
> >
> > Fine with me, do you want me to send you another patch with those changes?
>
> Yes please.

I sent a v2 patch changing those things you pointed out, however, the
whole comment[0] looks informal "But wait.. there's more" and I don't
think replacing "it's" with "it is" achieves a lot in this case.

[0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/ata/libata-core.c#n1399

Diego