linux-kernel - Re: [PATCH v3] perf intel-pt: Synthesize cycle events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52d31321-66e1-f189-2ffc-7c93239eea74@intel.com>
Date:   Wed, 23 Mar 2022 09:58:00 +0200
From:   Adrian Hunter <adrian.hunter@...el.com>
To:     "Steinar H. Gunderson" <sesse@...gle.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] perf intel-pt: Synthesize cycle events

On 22/03/2022 23:53, Steinar H. Gunderson wrote:
> On Tue, Mar 22, 2022 at 06:32:18PM -0300, Arnaldo Carvalho de Melo wrote:
>> I saw there was some issue, should I proceed and apply this v3 patch or
>> wait for some v4?
> 
> There are two issues in play:
> 
>  1. PT event synth doesn't support reading inline information from DWARF
>     yet, and my patch to add it runs into some problems. This is not
>     relevant for this patch at all.
>  2. The results from v3 don't quite match the ones from v1, and neither
>     of us are entirely sure why. My personal feeling is that the one
>     from v1 are the wrong ones, but it's up to Adrian to say whether we
>     want to try to investigate deeply here.

V3 is good.  Please take that.