linux-kernel - Re: [PATCH] ata: libata-core: fix "it's" typos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+ToGPGVdwXgWTZFa24PDMkpXrVrpM48WAxR4U6d4D9t-k=nJQ@mail.gmail.com>
Date:   Wed, 23 Mar 2022 05:44:39 -0300
From:   Diego Viola <diego.viola@...il.com>
To:     Damien Le Moal <damien.lemoal@...nsource.wdc.com>
Cc:     linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
        corbet@....net
Subject: Re: [PATCH] ata: libata-core: fix "it's" typos

On Wed, Mar 23, 2022 at 5:17 AM Damien Le Moal
<damien.lemoal@...nsource.wdc.com> wrote:
>
> On 3/23/22 16:24, Diego Viola wrote:
> > On Wed, Mar 23, 2022 at 2:53 AM Damien Le Moal
> > <damien.lemoal@...nsource.wdc.com> wrote:
> >>
> >> On 3/23/22 14:52, Diego Viola wrote:
> >>> On Wed, Mar 23, 2022 at 2:45 AM Damien Le Moal
> >>> <damien.lemoal@...nsource.wdc.com> wrote:
> >>>>
> >>>> On 3/23/22 14:40, Diego Viola wrote:
> >>>>> Use the contraction "it's" instead of the possessive form "its".
> >>>>
> >>>> Well, while at it, let's use proper formal written English, so:
> >>>> s/it's/it is
> >>>> s/isn't/is not
> >>>
> >>> Fine with me, do you want me to send you another patch with those changes?
> >>
> >> Yes please.
> >
> > I sent a v2 patch changing those things you pointed out, however, the
> > whole comment[0] looks informal "But wait.. there's more" and I don't
> > think replacing "it's" with "it is" achieves a lot in this case.
>
> :)
>
> Indeed. Do you want it in or can I drop it ?

Given that the language is mostly informal, I'd rather see the first
patch applied (if that is OK with you). However, I agree with you that
it would be nice to see formal language used, I just don't think I'm
the right person to change all the comments in that file. :(

Thanks,
Diego