linux-kernel - Re: [PATCH 2/2] Revert "virtio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878rt1xcq2.wl-maz@kernel.org>
Date:   Wed, 23 Mar 2022 09:03:17 +0000
From:   Marc Zyngier <maz@...nel.org>
To:     Jason Wang <jasowang@...hat.com>
Cc:     mst@...hat.com, virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org, tglx@...utronix.de,
        peterz@...radead.org, Stefano Garzarella <sgarzare@...hat.com>,
        Keir Fraser <keirf@...gle.com>
Subject: Re: [PATCH 2/2] Revert "virtio_pci: harden MSI-X interrupts"

On Wed, 23 Mar 2022 03:15:24 +0000,
Jason Wang <jasowang@...hat.com> wrote:
> 
> This reverts commit 9e35276a5344f74d4a3600fc4100b3dd251d5c56. Issue
> were reported for the drivers that are using affinity managed IRQ
> where manually toggling IRQ status is not expected. And we forget to
> enable the interrupts in the restore path as well.
> 
> In the future, we will rework on the interrupt hardening.
> 
> Fixes: 9e35276a5344 ("virtio_pci: harden MSI-X interrupts")
> Reported-by: Marc Zyngier <maz@...nel.org>
> Reported-by: Stefano Garzarella <sgarzare@...hat.com>
> Signed-off-by: Jason Wang <jasowang@...hat.com>

For this patch and the INTx one:

Acked-by: Marc Zyngier <maz@...nel.org>

Please keep me in the loop when you decide to rework this.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.