linux-kernel - Re: [PATCH 2/2] Revert "virtio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACGkMEu-sQZO6-LBsLAzw4bqQpua1DXYLcAukjCtd43P3Ei4Ow@mail.gmail.com>
Date:   Wed, 23 Mar 2022 17:21:34 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     Marc Zyngier <maz@...nel.org>
Cc:     mst <mst@...hat.com>,
        virtualization <virtualization@...ts.linux-foundation.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Stefano Garzarella <sgarzare@...hat.com>,
        Keir Fraser <keirf@...gle.com>
Subject: Re: [PATCH 2/2] Revert "virtio_pci: harden MSI-X interrupts"

On Wed, Mar 23, 2022 at 5:05 PM Marc Zyngier <maz@...nel.org> wrote:
>
> On Wed, 23 Mar 2022 03:15:24 +0000,
> Jason Wang <jasowang@...hat.com> wrote:
> >
> > This reverts commit 9e35276a5344f74d4a3600fc4100b3dd251d5c56. Issue
> > were reported for the drivers that are using affinity managed IRQ
> > where manually toggling IRQ status is not expected. And we forget to
> > enable the interrupts in the restore path as well.
> >
> > In the future, we will rework on the interrupt hardening.
> >
> > Fixes: 9e35276a5344 ("virtio_pci: harden MSI-X interrupts")
> > Reported-by: Marc Zyngier <maz@...nel.org>
> > Reported-by: Stefano Garzarella <sgarzare@...hat.com>
> > Signed-off-by: Jason Wang <jasowang@...hat.com>
>
> For this patch and the INTx one:
>
> Acked-by: Marc Zyngier <maz@...nel.org>
>
> Please keep me in the loop when you decide to rework this.

Ok.

Thanks

>
> Thanks,
>
>         M.
>
> --
> Without deviation from the norm, progress is not possible.
>