linux-kernel - Re: [PATCH 2/2] drivers: usb: dwc3: Add AM62 USB wrapper driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 23 Mar 2022 20:17:22 +0800
From:   kernel test robot <lkp@...el.com>
To:     Aswath Govindraju <a-govindraju@...com>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-usb@...r.kernel.org, Felipe Balbi <balbi@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Roger Quadros <rogerq@...nel.org>,
        Vignesh Raghavendra <vigneshr@...com>,
        Kishon Vijay Abraham I <kishon@...com>,
        Aswath Govindraju <a-govindraju@...com>
Subject: Re: [PATCH 2/2] drivers: usb: dwc3: Add AM62 USB wrapper driver

Hi Aswath,

I love your patch! Yet something to improve:

[auto build test ERROR on linux/master]
[also build test ERROR on usb/usb-testing linus/master v5.17 next-20220323]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Aswath-Govindraju/AM62-Add-support-for-AM62-USB-wrapper-driver/20220323-133708
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 2c271fe77d52a0555161926c232cd5bc07178b39
config: hexagon-buildonly-randconfig-r002-20220323 (https://download.01.org/0day-ci/archive/20220323/202203232002.K45zQUfY-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 902f4708fe1d03b0de7e5315ef875006a6adc319)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/4ca423573f638454724a40416042d84552db81af
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Aswath-Govindraju/AM62-Add-support-for-AM62-USB-wrapper-driver/20220323-133708
        git checkout 4ca423573f638454724a40416042d84552db81af
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/usb/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/usb/dwc3/dwc3-am62.c:567:10: error: use of undeclared identifier 'dwc3_ti_pm_ops'; did you mean 'dwc3_ti_probe'?
                   .pm     = &dwc3_ti_pm_ops,
                              ^~~~~~~~~~~~~~
                              dwc3_ti_probe
   drivers/usb/dwc3/dwc3-am62.c:379:12: note: 'dwc3_ti_probe' declared here
   static int dwc3_ti_probe(struct platform_device *pdev)
              ^
>> drivers/usb/dwc3/dwc3-am62.c:567:9: error: incompatible pointer types initializing 'const struct dev_pm_ops *' with an expression of type 'int (*)(struct platform_device *)' [-Werror,-Wincompatible-pointer-types]
                   .pm     = &dwc3_ti_pm_ops,
                             ^~~~~~~~~~~~~~~
   2 errors generated.


vim +567 drivers/usb/dwc3/dwc3-am62.c

   561	
   562	static struct platform_driver dwc3_ti_driver = {
   563		.probe		= dwc3_ti_probe,
   564		.remove		= dwc3_ti_remove,
   565		.driver		= {
   566			.name	= "dwc3-am62",
 > 567			.pm	= &dwc3_ti_pm_ops,
   568			.of_match_table = dwc3_ti_of_match,
   569		},
   570	};
   571	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp