linux-kernel - Re: [PATCH] PCI: Avoid broken MSI on SB600 USB devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a1bf31d6a8957b837b999c02875456b805efdff1.camel@infradead.org>
Date:   Wed, 23 Mar 2022 12:43:48 +0000
From:   David Woodhouse <dwmw2@...radead.org>
To:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Bjorn Helgaas <helgaas@...nel.org>
Cc:     linux-pci <linux-pci@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Mick Lorain <micklorain@...tonmail.com>,
        Alex Williamson <alex.williamson@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH] PCI: Avoid broken MSI on SB600 USB devices

On Wed, 2022-03-23 at 10:03 +0200, Andy Shevchenko wrote:
> On Wed, Mar 23, 2022 at 4:26 AM Bjorn Helgaas <helgaas@...nel.org> wrote:
> 
> > On Mon, Mar 21, 2022 at 01:34:46PM -0500, Bjorn Helgaas wrote:
> > > From: Bjorn Helgaas <bhelgaas@...gle.com>
> > > Some ATI SB600 USB adapters advertise MSI, but if INTx is disabled by
> > > setting PCI_COMMAND_INTX_DISABLE,
> 
> > > MSI doesn't work either.
> 
> I think this is not correct.

I think it was perfectly correct until you added a couple of newlines
in the middle of the sentence, then took it out of context. :)

"If INTX is disabled, MSI doesn't work either".

But really, in that case surely the solution is *not* to disable INTX
for this device. Then MSI will work, right?

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5965 bytes)