linux-kernel - Re: [PATCH net-next] net: dsa: realtek: make interface drivers depend on OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YjsZVblL11w8IuRH@lunn.ch>
Date:   Wed, 23 Mar 2022 13:57:57 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Alvin Šipraga <alvin@...s.dk>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Alvin Šipraga <alsi@...g-olufsen.dk>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: dsa: realtek: make interface drivers
 depend on OF

On Wed, Mar 23, 2022 at 01:42:25PM +0100, Alvin Šipraga wrote:
> From: Alvin Šipraga <alsi@...g-olufsen.dk>
> 
> The kernel test robot reported build warnings with a randconfig that
> built realtek-{smi,mdio} without CONFIG_OF set. Since both interface
> drivers are using OF and will not probe without, add the corresponding
> dependency to Kconfig.
> 
> Link: https://lore.kernel.org/all/202203231233.Xx73Y40o-lkp@intel.com/
> Link: https://lore.kernel.org/all/202203231439.ycl0jg50-lkp@intel.com/
> Signed-off-by: Alvin Šipraga <alsi@...g-olufsen.dk>

Hi Alvin

This looks like something which could go into net, not net-next. Could
you add a Fixes: tag.

Otherwise

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew