linux-kernel - Re: [PATCH v2] ksmbd: Remove a redundant zeroing of memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKYAXd_ZP6-dHFJ80cNDJBP+de=CeLrMqbwiHd58++qqFoESRQ@mail.gmail.com>
Date:   Wed, 23 Mar 2022 22:51:44 +0900
From:   Namjae Jeon <linkinjeon@...nel.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Sergey Senozhatsky <senozhatsky@...omium.org>,
        Steve French <sfrench@...ba.org>,
        Hyunchul Lee <hyc.lee@...il.com>, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-cifs@...r.kernel.org
Subject: Re: [PATCH v2] ksmbd: Remove a redundant zeroing of memory

2022-03-23 15:32 GMT+09:00, Christophe JAILLET <christophe.jaillet@...adoo.fr>:
> fill_transform_hdr() has only one caller that already clears tr_buf (it is
> kzalloc'ed).
>
> So there is no need to clear it another time here.
>
> Remove the superfluous memset() and add a comment to remind that the caller
> must clear the buffer.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Acked-by: Namjae Jeon <linkinjeon@...nel.org>

Thanks!