linux-kernel - Re: [PATCH] USB4/TBT device routers should wake up during S0ix when something gets connected/disconnected or a DP monitor gets plugged in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 23 Mar 2022 07:30:54 -0700
From:   Benson Leung <bleung@...gle.com>
To:     "Khandelwal, Rajat" <rajat.khandelwal@...el.com>
Cc:     "mika.westerberg@...ux.intel.com" <mika.westerberg@...ux.intel.com>,
        "Malani, Prashant" <pmalani@...gle.com>,
        "jthies@...gle.com" <jthies@...gle.com>,
        "Rao, Abhijeet" <abhijeet.rao@...el.com>,
        "Regupathy, Rajaram" <rajaram.regupathy@...el.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Westerberg, Mika" <mika.westerberg@...el.com>
Subject: Re: [PATCH] USB4/TBT device routers should wake up during S0ix when
 something gets connected/disconnected or a DP monitor gets plugged in

Hi Rajat,

On Wed, Mar 23, 2022 at 3:26 AM Khandelwal, Rajat
<rajat.khandelwal@...el.com> wrote:
>
> +Mika
> @Malani, Prashant @bleung@...gle.com This is the patch which fixes the partner issue. Kindly escalate your thoughts.
>
> Thanks
> Rajat
>
> -----Original Message-----
> From: Khandelwal, Rajat <rajat.khandelwal@...el.com>
> Sent: Wednesday, March 23, 2022 3:48 PM
> To: mika.westerberg@...ux.intel.com
> Cc: Khandelwal, Rajat <rajat.khandelwal@...el.com>; bleung@...gle.com; jthies@...gle.com; Malani, Prashant <pmalani@...gle.com>; Rao, Abhijeet <abhijeet.rao@...el.com>; Regupathy, Rajaram <rajaram.regupathy@...el.com>; linux-usb@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH] USB4/TBT device routers should wake up during S0ix when something gets connected/disconnected or a DP monitor gets plugged in
>
> Device routers don't wake up during S0ix when something is plugged in/out or if a DP monitor gets connected. This causes the linux device to not wake up during S0ix cycling as the host router didn't wake up because the device router didn't. This patch adds a new functionality to linux.
>
> Signed-off-by: Rajat-Khandelwal <rajat.khandelwal@...el.com>
> ---
>  drivers/thunderbolt/switch.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/thunderbolt/switch.c b/drivers/thunderbolt/switch.c index d026e305fe5d..4f8056724aa4 100644
> --- a/drivers/thunderbolt/switch.c
> +++ b/drivers/thunderbolt/switch.c
> @@ -3067,13 +3067,11 @@ void tb_switch_suspend(struct tb_switch *sw, bool runtime)
>                         tb_switch_suspend(port->remote->sw, runtime);
>         }
>
> -       if (runtime) {
> +       if (runtime || device_may_wakeup(&sw->dev)) {
>                 /* Trigger wake when something is plugged in/out */
>                 flags |= TB_WAKE_ON_CONNECT | TB_WAKE_ON_DISCONNECT;
>                 flags |= TB_WAKE_ON_USB4;
>                 flags |= TB_WAKE_ON_USB3 | TB_WAKE_ON_PCIE | TB_WAKE_ON_DP;
> -       } else if (device_may_wakeup(&sw->dev)) {
> -               flags |= TB_WAKE_ON_USB4 | TB_WAKE_ON_USB3 | TB_WAKE_ON_PCIE;
>         }
>
>         tb_switch_set_wake(sw, flags);
> --
> 2.17.1
>


Can you please help double check your email configuration for sending
patches and responses to the mailing list?
I've checked the linux-usb mailing list archives and they don't
capture your original patch email or your forward.
https://marc.info/?l=linux-usb&r=1&b=202203&w=2

I did find Mika's response to your forward, though.

Let's get this figured out so that folks can have an easier time
applying your patches for evaluation with b4 or
similar tools.

Thanks,

Benson

-- 
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@...gle.com
Chromium OS Project
bleung@...omium.org