linux-kernel - Re: [PATCH -next] ASoC: SOF: Intel: Fix build error without SND_SOC_SOF_PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9f44016c-4774-64b3-4485-630401710568@linux.intel.com>
Date:   Wed, 23 Mar 2022 09:57:06 -0500
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     Zheng Bin <zhengbin13@...wei.com>, lgirdwood@...il.com,
        ranjani.sridharan@...ux.intel.com, kai.vehmanen@...ux.intel.com,
        daniel.baluta@....com, broonie@...nel.org, perex@...ex.cz,
        tiwai@...e.com, peter.ujfalusi@...ux.intel.com,
        sound-open-firmware@...a-project.org, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Cc:     limingming.li@...wei.com, tangyizhou@...wei.com
Subject: Re: [PATCH -next] ASoC: SOF: Intel: Fix build error without
 SND_SOC_SOF_PCI_DEV



On 3/23/22 04:25, Zheng Bin wrote:
> If SND_SOC_SOF_PCI_DEV is n, bulding fails:
> 
> sound/soc/sof/intel/pci-tng.o:(.data+0x1c0): undefined reference to `sof_pci_probe'
> sound/soc/sof/intel/pci-tng.o:(.data+0x1c8): undefined reference to `sof_pci_remove'
> sound/soc/sof/intel/pci-tng.o:(.data+0x1e0): undefined reference to `sof_pci_shutdown'
> sound/soc/sof/intel/pci-tng.o:(.data+0x290): undefined reference to `sof_pci_pm'
> 
> Make SND_SOC_SOF_MERRIFIELD select SND_SOC_SOF_PCI_DEV to fix this.
> 
> Fixes: 8d4ba1be3d22 ("ASoC: SOF: pci: split PCI into different drivers")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zheng Bin <zhengbin13@...wei.com>

Indeed that's a miss, thanks for the patch. We select 
SND_SOC_SOF_PCI_DEV for all HDaudio-based PCI devices but forgot 
Merrifield which is PCI-based but not HDaudio-based.

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>

> ---
>   sound/soc/sof/intel/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/sof/intel/Kconfig b/sound/soc/sof/intel/Kconfig
> index b53f216d4ecc..172419392b33 100644
> --- a/sound/soc/sof/intel/Kconfig
> +++ b/sound/soc/sof/intel/Kconfig
> @@ -84,6 +84,7 @@ if SND_SOC_SOF_PCI
>   config SND_SOC_SOF_MERRIFIELD
>   	tristate "SOF support for Tangier/Merrifield"
>   	default SND_SOC_SOF_PCI
> +	select SND_SOC_SOF_PCI_DEV
>   	select SND_SOC_SOF_INTEL_ATOM_HIFI_EP
>   	help
>   	  This adds support for Sound Open Firmware for Intel(R) platforms
> --
> 2.31.1
>