lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 23 Mar 2022 16:06:04 +0100 From: Krzysztof Kozlowski <krzk@...nel.org> To: Jonathan Bakker <xc-racer2@...e.ca>, alim.akhtar@...sung.com Cc: robh+dt@...nel.org, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/7] ARM: dts: s5pv210: Split memory nodes to match spec On 23/03/2022 15:59, Jonathan Bakker wrote: > Hi Krzysztof, > > On 2022-03-23 3:54 a.m., Krzysztof Kozlowski wrote: >> On 22/03/2022 21:11, Jonathan Bakker wrote: >>> Memory nodes should only have a singular reg property in them, so >>> split the memory nodes such that there is only per node. >>> >>> Signed-off-by: Jonathan Bakker <xc-racer2@...e.ca> >>> --- >>> arch/arm/boot/dts/s5pv210-aquila.dts | 8 ++++++-- >>> arch/arm/boot/dts/s5pv210-aries.dtsi | 14 +++++++++++--- >>> arch/arm/boot/dts/s5pv210-goni.dts | 14 +++++++++++--- >>> 3 files changed, 28 insertions(+), 8 deletions(-) >>> >>> diff --git a/arch/arm/boot/dts/s5pv210-aquila.dts b/arch/arm/boot/dts/s5pv210-aquila.dts >>> index 6423348034b6..6984479ddba3 100644 >>> --- a/arch/arm/boot/dts/s5pv210-aquila.dts >>> +++ b/arch/arm/boot/dts/s5pv210-aquila.dts >>> @@ -29,8 +29,12 @@ >>> >>> memory@...00000 { >>> device_type = "memory"; >>> - reg = <0x30000000 0x05000000 >>> - 0x40000000 0x18000000>; >>> + reg = <0x30000000 0x05000000>; >>> + }; >>> + >>> + memory@...00000 { >>> + device_type = "memory"; >>> + reg = <0x40000000 0x18000000>; >>> }; >>> >>> pmic_ap_clk: clock-0 { >>> diff --git a/arch/arm/boot/dts/s5pv210-aries.dtsi b/arch/arm/boot/dts/s5pv210-aries.dtsi >>> index 160f8cd9a68d..70ff56daf4cb 100644 >>> --- a/arch/arm/boot/dts/s5pv210-aries.dtsi >>> +++ b/arch/arm/boot/dts/s5pv210-aries.dtsi >>> @@ -24,9 +24,17 @@ >>> >>> memory@...00000 { >>> device_type = "memory"; >>> - reg = <0x30000000 0x05000000 >>> - 0x40000000 0x10000000 >>> - 0x50000000 0x08000000>; >> >> 0x40000000 to 0x58000000 is continues, so I wonder why it is split? Look >> at Aquila DTS. >> >> > > Yes, it was split in the vendor kernel as well [1], and that's been continued along > here. I personally don't see a reason to keep it split, but there might be something > I'm not aware of. > I guess they wanted maybe to express the physical banks. Fine with me. Just your explanation is not entirely correct: > Memory nodes should only have a singular reg property in them, one reg but it can have multiple items. Why do think multiple reg items is not allowed? Best regards, Krzysztof
Powered by blists - more mailing lists