linux-kernel - Re: [PATCH V2] android: binder: Fix duplicate included binder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHRSSEw2+-GpQe5Ufea1U-fQ4YkL1UR_T4Pt5UjWsgRiF+esDA@mail.gmail.com>
Date:   Wed, 23 Mar 2022 08:21:09 -0700
From:   Todd Kjos <tkjos@...gle.com>
To:     Haowen Bai <baihaowen@...zu.com>
Cc:     gregkh@...uxfoundation.org, arve@...roid.com, tkjos@...roid.com,
        maco@...roid.com, joel@...lfernandes.org, brauner@...nel.org,
        hridya@...gle.com, surenb@...gle.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] android: binder: Fix duplicate included binder_trace.h

On Tue, Mar 22, 2022 at 8:12 PM Haowen Bai <baihaowen@...zu.com> wrote:
>
> Clean up the following includecheck warning:
>
> drivers/android/binder.c: binder_trace.h is included more than once.
>
> No functional change.
>
> Signed-off-by: Haowen Bai <baihaowen@...zu.com>
> ---
> V1 -> V2: modify title asm/pgtable.h -> binder_trace.h
>
>  drivers/android/binder.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index 8351c56..a12aa3c 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -72,7 +72,6 @@
>  #include <linux/cacheflush.h>
>
>  #include "binder_internal.h"
> -#include "binder_trace.h"

This breaks the build. Please test your changes before submitting.

>
>  static HLIST_HEAD(binder_deferred_list);
>  static DEFINE_MUTEX(binder_deferred_lock);
> --
> 2.7.4
>