linux-kernel - Re: [PATCH v2] brcmfmac: Avoid keeping power to SDIO card unless WOWL is used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a6dgk63l.fsf@kernel.org>
Date:   Wed, 23 Mar 2022 18:04:46 +0200
From:   Kalle Valo <kvalo@...nel.org>
To:     Yann Gautier <yann.gautier@...s.st.com>
Cc:     Ulf Hansson <ulf.hansson@...aro.org>,
        <linux-wireless@...r.kernel.org>,
        Christophe ROULLIER-SCND-02 <christophe.roullier@...s.st.com>,
        Arend van Spriel <aspriel@...il.com>,
        Franky Lin <franky.lin@...adcom.com>,
        Hante Meuleman <hante.meuleman@...adcom.com>,
        Gustavo Padovan <gustavo.padovan@...labora.com>,
        Adrian Ratiu <adrian.ratiu@...labora.com>,
        <brcm80211-dev-list.pdl@...adcom.com>,
        <linux-kernel@...r.kernel.org>,
        Christophe KERELLO - foss <christophe.kerello@...s.st.com>
Subject: Re: [PATCH v2] brcmfmac: Avoid keeping power to SDIO card unless WOWL is used

Yann Gautier <yann.gautier@...s.st.com> writes:

> On 3/23/22 09:39, Ulf Hansson wrote:
>> Keeping the power to the SDIO card during system wide suspend, consumes
>> energy. Especially on battery driven embedded systems, this can be a
>> problem. Therefore, let's change the behaviour into allowing the SDIO card
>> to be powered off, unless WOWL is supported and enabled.
>>
>> Note that, the downside from this change, is that during system resume the
>> SDIO card needs to be re-initialized and the FW must be re-programmed. Even
>> if this may take some time to complete, it should we worth it, rather than
>> draining the battery.
>>
>> Signed-off-by: Ulf Hansson <ulf.hansson@...aro.org>
>
> Thanks for the patch, it is OK, and tested by Christophe (R.).
> So you can add:
> Tested-by: Christophe Roullier <christophe.roullier@...s.st.com>
> Acked-by: Yann Gautier <yann.gautier@...s.st.com>

Acked-by is used by the driver maintainer, so I assume you mean
Reviewed-by?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches