linux-kernel - Re: [PATCH v2 0/3] Refactor xhci quirks and plat private data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220323030749.GO23316@hu-pkondeti-hyd.qualcomm.com>
Date:   Wed, 23 Mar 2022 08:37:49 +0530
From:   Pavan Kondeti <quic_pkondeti@...cinc.com>
To:     Mathias Nyman <mathias.nyman@...ux.intel.com>
CC:     "Sandeep Maheswaram (Temp)" <quic_c_sanm@...cinc.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Mathias Nyman <mathias.nyman@...el.com>,
        Felipe Balbi <balbi@...nel.org>,
        Stephen Boyd <swboyd@...omium.org>,
        "Doug Anderson" <dianders@...omium.org>,
        Matthias Kaehlcke <mka@...omium.org>,
        "Pawel Laszczak" <pawell@...ence.com>,
        Peter Chen <peter.chen@...nel.org>,
        "Roger Quadros" <rogerq@...nel.org>,
        Aswath Govindraju <a-govindraju@...com>,
        <linux-arm-msm@...r.kernel.org>, <linux-usb@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <quic_pkondeti@...cinc.com>,
        <quic_ppratap@...cinc.com>
Subject: Re: [PATCH v2 0/3] Refactor xhci quirks and plat private data

Hi Mathias,

On Tue, Mar 22, 2022 at 05:53:42PM +0200, Mathias Nyman wrote:
> On 21.3.2022 8.21, Sandeep Maheswaram (Temp) wrote:
> > Hi Mathias,
> > 
> > On 3/18/2022 5:29 PM, Greg Kroah-Hartman wrote:
> >> On Thu, Mar 17, 2022 at 11:17:17AM +0530, Sandeep Maheswaram (Temp) wrote:
> >>> Hi Greg,
> >>>
> >>> On 3/1/2022 3:58 PM, Sandeep Maheswaram wrote:
> >>>> changes in v2:
> >>>> Added a PATCH 2/3 to remove unwanted header inclusion.
> >>>> Fixed minor nitpicks in PATCH 3/3.
> >>>>
> >>>> Pavankumar Kondeti (1):
> >>>>     usb: xhci: refactor quirks and plat private data
> >>>>
> >>>> Sandeep Maheswaram (2):
> >>>>     usb: xhci: Remove unwanted header inclusion
> >>>>     usb: dwc: host: add xhci_plat_priv quirk XHCI_SKIP_PHY_INIT
> >>>>
> >>>>    drivers/usb/cdns3/host.c        |  2 +-
> >>>>    drivers/usb/dwc3/host.c         | 13 ++++++++
> >>>>    drivers/usb/host/xhci-plat.c    |  3 +-
> >>>>    drivers/usb/host/xhci-plat.h    | 24 ---------------
> >>>>    drivers/usb/host/xhci-rcar.c    |  3 +-
> >>>>    drivers/usb/host/xhci.h         | 60 ++++--------------------------------
> >>>>    include/linux/usb/xhci-plat.h   | 24 +++++++++++++++
> >>>>    include/linux/usb/xhci-quirks.h | 67 +++++++++++++++++++++++++++++++++++++++++
> >>>>    8 files changed, 115 insertions(+), 81 deletions(-)
> >>>>    delete mode 100644 drivers/usb/host/xhci-plat.h
> >>>>    create mode 100644 include/linux/usb/xhci-plat.h
> >>>>    create mode 100644 include/linux/usb/xhci-quirks.h
> >>> Please let me know your opinion about this patch series.
> >> I need the xhci maintainer to review it...
> >>
> >> thanks,
> >>
> >> greg k-h
> > 
> > 
> > Can you please review this patch series.
> > 
> 
> I don't have a better solution than this.
> 
> So neither devicetree or ACPI entries exists for the xHC part of this dwc3 controller?
> 
> A pure platform device is created, and it matches and binds to xhci-plat driver by "xhci-hcd" name.
> I guess we have no way to identify this dwc3 xhci controller in xhci-plat.c, and set quirks there,
> like all those devicetree xhci devices that we set quirks based on .compatibility. 
> 
Thanks for the review. Yes, xhci-plat platform device is created by the DWC3
driver for the controllers that needs to be operated in the host.

Thanks,
Pavan