linux-kernel - [PATCH] cacheflush.h: Add forward declaration for struct folio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <YjqVblTmjNYl3Zjc@gondor.apana.org.au>
Date:   Wed, 23 Mar 2022 15:35:10 +1200
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Guenter Roeck <linux@...ck-us.net>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Cc:     Harsha <harsha.harsha@...inx.com>,
        Linux Crypto Mailing List <linux-crypto@...r.kernel.org>,
        Matthew Wilcox <willy@...radead.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: [PATCH] cacheflush.h: Add forward declaration for struct folio

On Tue, Mar 22, 2022 at 06:13:27AM -0700, Guenter Roeck wrote:
> On Wed, Mar 09, 2022 at 03:20:01PM +1200, Herbert Xu wrote:
> > This patch turns the new SHA driver into a tristate and also allows
> > compile testing.
> > 
> > Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>
> 
> This results in:
> 
> Building s390:allmodconfig ... failed
> --------------
> Error log:
> In file included from drivers/crypto/xilinx/zynqmp-sha.c:6:
> include/linux/cacheflush.h:12:46: error: 'struct folio' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
>    12 | static inline void flush_dcache_folio(struct folio *folio)

This should be fixed in cacheflush.h:

---8<---
The struct folio is not declared in cacheflush.h so we need to
provide a forward declaration as otherwise users of this header
file may get warnings.

Reported-by: Guenter Roeck <linux@...ck-us.net>
Fixes: 522a0032af00 ("Add linux/cacheflush.h")
Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

diff --git a/include/linux/cacheflush.h b/include/linux/cacheflush.h
index fef8b607f97e..a6189d21f2ba 100644
--- a/include/linux/cacheflush.h
+++ b/include/linux/cacheflush.h
@@ -4,6 +4,8 @@
 
 #include <asm/cacheflush.h>
 
+struct folio;
+
 #if ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE
 #ifndef ARCH_IMPLEMENTS_FLUSH_DCACHE_FOLIO
 void flush_dcache_folio(struct folio *folio);
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt