linux-kernel - Re: [PATCH 0/2] nolibc: fix two build issues at -O0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220323231603.GS4285@paulmck-ThinkPad-P17-Gen-1>
Date:   Wed, 23 Mar 2022 16:16:03 -0700
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Willy Tarreau <w@....eu>
Cc:     linux-kernel@...r.kernel.org, Ammar Faizi <ammarfaizi2@...weeb.org>
Subject: Re: [PATCH 0/2] nolibc: fix two build issues at -O0

On Wed, Mar 23, 2022 at 08:18:05AM +0100, Willy Tarreau wrote:
> Hello Paul,
> 
> please find in this series two build fixes to apply on top of the series
> you've already queued:
>  - gcc errors at -O0 because it doesn't eliminate non-inline code and
>    keeps the reference to the external "environ" from getenv()
>  - clang fails at -O0 because __builtin_strlen() calls strlen()
> 
> I don't care about optimizing at -O0 by definition but at least it should
> build and work correctly! I've verified that rcutorture still runs.

Queued with Ammar's Tested-by, thank you both!

							Thanx, Paul

> Thanks!
> Willy
> 
> ---
> Willy Tarreau (2):
>   tools/nolibc/string: do not use __builtin_strlen() at -O0
>   tools/nolibc/stdlib: only reference the external environ when inlined
> 
>  tools/include/nolibc/stdlib.h | 22 +++++++++++++++-------
>  tools/include/nolibc/string.h | 11 ++++++++++-
>  2 files changed, 25 insertions(+), 8 deletions(-)
> 
> -- 
> 2.35.1
>