linux-kernel - Re: [PATCH] selftests/seccomp: Don't call read() on TTY from background pgrp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <164816410448.1364331.9275240397611057038.b4-ty@chromium.org>
Date:   Thu, 24 Mar 2022 16:21:48 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Jann Horn <jannh@...gle.com>
Cc:     Kees Cook <keescook@...omium.org>, linux-kernel@...r.kernel.org,
        Will Drewry <wad@...omium.org>,
        Andy Lutomirski <luto@...capital.net>
Subject: Re: [PATCH] selftests/seccomp: Don't call read() on TTY from background pgrp

On Sat, 19 Mar 2022 02:00:11 +0100, Jann Horn wrote:
> Since commit 92d25637a3a4 ("kselftest: signal all child processes"), tests
> are executed in background process groups. This means that trying to read
> from stdin now throws SIGTTIN when stdin is a TTY, which breaks some
> seccomp selftests that try to use read(0, NULL, 0) as a dummy syscall.
> 
> The simplest way to fix that is probably to just use -1 instead of 0 as
> the dummy read()'s FD.
> 
> [...]

Applied to for-next/seccomp, thanks!

[1/1] selftests/seccomp: Don't call read() on TTY from background pgrp
      https://git.kernel.org/kees/c/1d27adee48cf

-- 
Kees Cook