linux-kernel - Re: [PATCH v4,2/6] dt-bindings: pwm: Remove compatible for MediaTek MT8167

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 25 Mar 2022 07:48:24 +0800
From:   Miles Chen <miles.chen@...iatek.com>
To:     <xinlei.lee@...iatek.com>
CC:     <Project_Global_Chrome_Upstream_Group@...iatek.com>,
        <allen-kh.cheng@...iatek.com>, <devicetree@...r.kernel.org>,
        <jitao.shi@...iatek.com>, <lee.jones@...aro.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-mediatek@...ts.infradead.org>, <linux-pwm@...r.kernel.org>,
        <matthias.bgg@...il.com>, <rex-bc.chen@...iatek.com>,
        <robh+dt@...nel.org>, <thierry.reding@...il.com>,
        <u.kleine-koenig@...gutronix.de>
Subject: Re: [PATCH v4,2/6] dt-bindings: pwm: Remove compatible for MediaTek MT8167

Hi Xinlei,

> Remove dt-binding documentation of pwm for MediaTek MT8167 SoC.
> I did not find the compatiable corresponding to mt8167 
> in the latest version of the pwm-mtk-disp.c driver file.
> It may be disabled but not updated to the dt_binding file.
> 
> Signed-off-by: Xinlei Lee <xinlei.lee@...iatek.com>
> ---
>  Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> index f844695d605a..f18e8bbd13d2 100644
> --- a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> +++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> @@ -20,9 +20,6 @@ properties:
>            - mediatek,mt2701-disp-pwm
>            - mediatek,mt6595-disp-pwm
>            - mediatek,mt8173-disp-pwm
> -      - items:
> -          - const: mediatek,mt8167-disp-pwm
> -          - const: mediatek,mt8173-disp-pwm

I checked:
grep -e 'mediatek,mt8167-disp-pwm' -e 'mediatek,mt8173-disp-pwm' drivers/ -RnH
drivers/gpu/drm/mediatek/mtk_drm_drv.c:486:     { .compatible = "mediatek,mt8167-disp-pwm",
drivers/gpu/drm/mediatek/mtk_drm_drv.c:488:     { .compatible = "mediatek,mt8173-disp-pwm",

mediatek,mt8167-disp-pwm and mediatek,mt8173-disp-pwm are used in drivers/gpu/drm/mediatek/mtk_drm_drv.c.
(added by commit 58e4c5398200 ("drm/mediatek: Add support for main DDP path on MT8167"))

Is it ok to remove mediatek,mt8167-disp-pwm and mediatek,mt8173-disp-pwm?

Thanks,
Miles
>  
>    reg:
>      maxItems: 1