linux-kernel - Re: [PATCH v8 1/2] dt-bindings: watchdog: Add watchdog yaml file for Sunplus SP7021

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <920c9f2a-77b6-4d68-a7c2-08967fab70cc@roeck-us.net>
Date:   Wed, 23 Mar 2022 20:36:22 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Xiantao Hu <xt.hu@...lus1.com>, krzk@...nel.org,
        wim@...ux-watchdog.org, p.zabel@...gutronix.de,
        linux-kernel@...r.kernel.org, linux-watchdog@...r.kernel.org,
        robh+dt@...nel.org, devicetree@...r.kernel.org
Cc:     wells.lu@...plus.com, qinjian@...lus1.com,
        Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v8 1/2] dt-bindings: watchdog: Add watchdog yaml file for
 Sunplus SP7021

On 3/23/22 20:18, Xiantao Hu wrote:
> This adds the documentation for the devicetree bindings of the Sunplus
> SP7021 watchdog driver, found from SP7021 SoCs and newer.
> 
> Reviewed-by: Krzysztof Kozlowski <krzk@...nel.org>
> Reviewed-by: Rob Herring <robh@...nel.org>
> Signed-off-by: Xiantao Hu <xt.hu@...lus1.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
> Changes in v8:
>   - Addressed all comments from Krzysztof Kozlowski.
>     1.fix the title.
>     2.fix the lowercase hex in examples.
> 
>   .../bindings/watchdog/sunplus,sp7021-wdt.yaml | 47 +++++++++++++++++++
>   MAINTAINERS                                   |  6 +++
>   2 files changed, 53 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/watchdog/sunplus,sp7021-wdt.yaml
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/sunplus,sp7021-wdt.yaml b/Documentation/devicetree/bindings/watchdog/sunplus,sp7021-wdt.yaml
> new file mode 100644
> index 000000000..d90271013
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/sunplus,sp7021-wdt.yaml
> @@ -0,0 +1,47 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) Sunplus Co., Ltd. 2021
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/sunplus,sp7021-wdt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sunplus SoCs Watchdog
> +
> +maintainers:
> +  - XianTao Hu <xt.hu@...lus1.com>
> +
> +allOf:
> +  - $ref: watchdog.yaml#
> +
> +properties:
> +  compatible:
> +    const: sunplus,sp7021-wdt
> +
> +  reg:
> +    items:
> +      - description: watchdog registers regions
> +      - description: miscellaneous control registers regions
> +
> +  clocks:
> +    maxItems: 1
> +
> +  resets:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - resets
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    watchdog: watchdog@...00630 {
> +        compatible = "sunplus,sp7021-wdt";
> +        reg = <0x9c000630 0x08>, <0x9c000274 0x04>;
> +        clocks = <&clkc 0x24>;
> +        resets = <&rstc 0x14>;
> +    };
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index cd0f68d4a..efdc618a0 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -18544,6 +18544,12 @@ S:	Maintained
>   F:	Documentation/devicetree/bindings/rtc/sunplus,sp7021-rtc.yaml
>   F:	drivers/rtc/rtc-sunplus.c
>   
> +SUNPLUS WATCHDOG DRIVER
> +M:	Xiantao Hu <xt.hu@...lus1.com>
> +L:	linux-watchdog@...r.kernel.org
> +S:	Maintained
> +F:	Documentation/devicetree/bindings/watchdog/sunplus,sp7021-wdt.yaml
> +
>   SUPERH
>   M:	Yoshinori Sato <ysato@...rs.sourceforge.jp>
>   M:	Rich Felker <dalias@...c.org>