linux-kernel - Re: [PATCH v1 1/4] auxdisplay: lcd2s: make use of device property API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yjw3/bnw/tomFvZd@smile.fi.intel.com>
Date:   Thu, 24 Mar 2022 11:21:01 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc:     Miguel Ojeda <ojeda@...nel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 1/4] auxdisplay: lcd2s: make use of device property API

On Wed, Mar 23, 2022 at 08:02:20PM +0100, Miguel Ojeda wrote:
> On Tue, Mar 8, 2022 at 4:11 PM Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:
> >
> > Make use of device property API in this driver so that both OF based
> > system and ACPI based system can use this driver.
> 
> I applied the series to -next, but for my understanding: the device
> property API was already being used, even if non-OF platforms couldn't
> use the driver before this patch, right? i.e. the commit message seems
> like the patch modified the calls.

Not really. The device property supports the PRP0001 special ACPI device
that makes use of OF matching mechanism (via usage of OF match table).
Without above change when CONFIG_OF=n, this may not work. I.o.w. device
properties per se in use, but the mechanism of matching is not working.

-- 
With Best Regards,
Andy Shevchenko