linux-kernel - [PATCH v3] mm/vmstat: add events for ksm cow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220324104332.2350482-1-yang.yang29@zte.com.cn>
Date:   Thu, 24 Mar 2022 10:43:33 +0000
From:   cgel.zte@...il.com
To:     akpm@...ux-foundation.org, david@...hat.com
Cc:     yang.yang29@....com.cn, ran.xiaokai@....com.cn,
        yang.shi@...ux.alibaba.com, dave.hansen@...ux.intel.com,
        minchan@...nel.org, saravanand@...com,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        xu xin <xu.xin16@....com.cn>
Subject: [PATCH v3] mm/vmstat: add events for ksm cow

From: Yang Yang <yang.yang29@....com.cn>

Users may use ksm by calling madvise(, , MADV_MERGEABLE) when they want
to save memory, it's a tradeoff by suffering delay on ksm cow. Users can
get to know how much memory ksm saved by reading
/sys/kernel/mm/ksm/pages_sharing, but they don't know what's the costs
of ksm cow, and this is important of some delay sensitive tasks.

So add ksm cow events to help users evaluate whether or how to use ksm.

Signed-off-by: Yang Yang <yang.yang29@....com.cn>
Reviewed-by: David Hildenbrand <david@...hat.com>
Reviewed-by: xu xin <xu.xin16@....com.cn>
Reviewed-by: Ran Xiaokai <ran.xiaokai@....com.cn>
---
v2:
- fix compile error when CONFIG_KSM is not set
v3:
- delete KSM_COW_FAIL event
---
 include/linux/vm_event_item.h | 1 +
 mm/memory.c                   | 4 ++++
 mm/vmstat.c                   | 1 +
 3 files changed, 6 insertions(+)

diff --git a/include/linux/vm_event_item.h b/include/linux/vm_event_item.h
index 16a0a4fd000b..d817ba541851 100644
--- a/include/linux/vm_event_item.h
+++ b/include/linux/vm_event_item.h
@@ -131,6 +131,7 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT,
 		SWAP_RA_HIT,
 #ifdef CONFIG_KSM
 		KSM_SWPIN_COPY,
+		COW_KSM,
 #endif
 #endif
 #ifdef CONFIG_X86
diff --git a/mm/memory.c b/mm/memory.c
index 4111f97c91a0..12925ceaf745 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -3339,6 +3339,10 @@ static vm_fault_t do_wp_page(struct vm_fault *vmf)
 	get_page(vmf->page);
 
 	pte_unmap_unlock(vmf->pte, vmf->ptl);
+#ifdef CONFIG_KSM
+	if (PageKsm(vmf->page))
+		count_vm_event(COW_KSM);
+#endif
 	return wp_page_copy(vmf);
 }
 
diff --git a/mm/vmstat.c b/mm/vmstat.c
index d5cc8d739fac..710d71af2285 100644
--- a/mm/vmstat.c
+++ b/mm/vmstat.c
@@ -1390,6 +1390,7 @@ const char * const vmstat_text[] = {
 	"swap_ra_hit",
 #ifdef CONFIG_KSM
 	"ksm_swpin_copy",
+	"cow_ksm",
 #endif
 #endif
 #ifdef CONFIG_X86
-- 
2.25.1