linux-kernel - Re: [PATCH 2/3] virtio: use virtio_reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220324110409.d3s4cgbomuaezv6h@sgarzare-redhat>
Date:   Thu, 24 Mar 2022 12:04:09 +0100
From:   Stefano Garzarella <sgarzare@...hat.com>
To:     Jason Wang <jasowang@...hat.com>
Cc:     mst@...hat.com, virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org, maz@...nel.org, tglx@...utronix.de,
        peterz@...radead.org, keirf@...gle.com
Subject: Re: [PATCH 2/3] virtio: use virtio_reset_device() when possible

On Thu, Mar 24, 2022 at 04:40:03PM +0800, Jason Wang wrote:
>This allows us to do common extension without duplicating codes.
>
>Signed-off-by: Jason Wang <jasowang@...hat.com>
>---
> drivers/virtio/virtio.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c
>index 75c8d560bbd3..8dde44ea044a 100644
>--- a/drivers/virtio/virtio.c
>+++ b/drivers/virtio/virtio.c
>@@ -430,7 +430,7 @@ int register_virtio_device(struct virtio_device *dev)
>
> 	/* We always start by resetting the device, in case a previous
> 	 * driver messed it up.  This also tests that code path a little. */
>-	dev->config->reset(dev);
>+	virtio_reset_device(dev);
>
> 	/* Acknowledge that we've seen the device. */
> 	virtio_add_status(dev, VIRTIO_CONFIG_S_ACKNOWLEDGE);
>@@ -496,7 +496,7 @@ int virtio_device_restore(struct virtio_device *dev)
>
> 	/* We always start by resetting the device, in case a previous
> 	 * driver messed it up. */
>-	dev->config->reset(dev);
>+	virtio_reset_device(dev);
>
> 	/* Acknowledge that we've seen the device. */
> 	virtio_add_status(dev, VIRTIO_CONFIG_S_ACKNOWLEDGE);
>-- 
>2.25.1
>

Reviewed-by: Stefano Garzarella <sgarzare@...hat.com>