linux-kernel - Re: [PATCH] scsi: ufs: core: Remove unused field in struct ufs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0034b2f8-0eba-f700-6fff-03cf5b8c8332@acm.org>
Date:   Thu, 24 Mar 2022 05:44:33 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     keosung.park@...sung.com, ALIM AKHTAR <alim.akhtar@...sung.com>,
        "avri.altman@....com" <avri.altman@....com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "beanhuo@...ron.com" <beanhuo@...ron.com>,
        Daejun Park <daejun7.park@...sung.com>,
        "adrian.hunter@...el.com" <adrian.hunter@...el.com>,
        "cang@...eaurora.org" <cang@...eaurora.org>,
        "asutoshd@...eaurora.org" <asutoshd@...eaurora.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: ufs: core: Remove unused field in struct ufs_hba

On 3/24/22 00:01, Keoseong Park wrote:
> Remove unused field "rpm_lvl_attr" and "spm_lvl_attr" in struct ufs_hba.
> Commit cbb6813ee771 ("scsi: ufs: sysfs: attribute group for existing
> sysfs entries.") removed all code using that field.
> 
> Signed-off-by: Keoseong Park <keosung.park@...sung.com>
> ---
>   drivers/scsi/ufs/ufshcd.h | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
> index 88c20f3608c2..94f545be183a 100644
> --- a/drivers/scsi/ufs/ufshcd.h
> +++ b/drivers/scsi/ufs/ufshcd.h
> @@ -820,8 +820,6 @@ struct ufs_hba {
>   	enum ufs_pm_level rpm_lvl;
>   	/* Desired UFS power management level during system PM */
>   	enum ufs_pm_level spm_lvl;
> -	struct device_attribute rpm_lvl_attr;
> -	struct device_attribute spm_lvl_attr;
>   	int pm_op_in_progress;
>   
>   	/* Auto-Hibernate Idle Timer register value */

Reviewed-by: Bart Van Assche <bvanassche@....org>