linux-kernel - Re: [RFC v1 01/10] roadtest: import libvhost-user from QEMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7f405d8d09a83954aa3411eff8b71ee687c7ec33.camel@sipsolutions.net>
Date:   Thu, 24 Mar 2022 14:00:10 +0100
From:   Johannes Berg <johannes@...solutions.net>
To:     Vincent Whitchurch <vincent.whitchurch@...s.com>,
        linux-kernel@...r.kernel.org
Cc:     kernel@...s.com, devicetree@...r.kernel.org,
        linux-um@...ts.infradead.org, shuah@...nel.org,
        brendanhiggins@...gle.com, linux-kselftest@...r.kernel.org,
        jic23@...nel.org, linux-iio@...r.kernel.org, lgirdwood@...il.com,
        broonie@...nel.org, a.zummo@...ertech.it,
        alexandre.belloni@...tlin.com, linux-rtc@...r.kernel.org,
        corbet@....net, linux-doc@...r.kernel.org
Subject: Re: [RFC v1 01/10] roadtest: import libvhost-user from QEMU

On Fri, 2022-03-11 at 17:24 +0100, Vincent Whitchurch wrote:
> Import the libvhost-user from QEMU for use in the implementation of the
> virtio devices in the roadtest backend.
> 

So hm, I wonder if this is the sensible thing to do?

Not that I mind importing qemu code, but:

 1) the implementation is rather complex in some places, and has support
    for a LOT of virtio/vhost-user features that are really not needed
    in these cases, for performance etc. It's also close to 4k LOC.

 2) the implementation doesn't support time-travel mode which might come
    in handy

We have another implementation that might be simpler:
https://github.com/linux-test-project/usfstl/blob/main/src/vhost.c

but it probably has dependencies on other things in this library, but
vhost.c itself is only ~1k LOC. (But I need to update it, I'm sure we
have some unpublished bugfixes etc. in this code)

johannes