linux-kernel - Re: [PATCH V2] wireless: broadcom: b43legacy: Fix assigning negative value to unsigned variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d7e3752e-0aad-e247-3708-41f7aba8248c@lwfinger.net>
Date:   Thu, 24 Mar 2022 10:58:22 -0500
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Haowen Bai <baihaowen@...zu.com>, kvalo@...nel.org
Cc:     linux-wireless@...r.kernel.org, b43-dev@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] wireless: broadcom: b43legacy: Fix assigning negative
 value to unsigned variable

On 3/24/22 03:06, Haowen Bai wrote:
> fix warning reported by smatch:
> drivers/net/wireless/broadcom/b43legacy/phy.c:1181 b43legacy_phy_lo_b_measure()
> warn: assigning (-772) to unsigned variable 'fval'
> 
> Signed-off-by: Haowen Bai <baihaowen@...zu.com>

This change makes no change to the executable code, but as long as it makes 
smatch happy -

Acked-by: Larry Finger <Larry.Finger@...inger.net>

Larry

> ---
> V1->V2: modify title of this patch
>   drivers/net/wireless/broadcom/b43legacy/phy.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/broadcom/b43legacy/phy.c b/drivers/net/wireless/broadcom/b43legacy/phy.c
> index 05404fb..c1395e6 100644
> --- a/drivers/net/wireless/broadcom/b43legacy/phy.c
> +++ b/drivers/net/wireless/broadcom/b43legacy/phy.c
> @@ -1123,7 +1123,7 @@ void b43legacy_phy_lo_b_measure(struct b43legacy_wldev *dev)
>   	struct b43legacy_phy *phy = &dev->phy;
>   	u16 regstack[12] = { 0 };
>   	u16 mls;
> -	u16 fval;
> +	s16 fval;
>   	int i;
>   	int j;
>