linux-kernel - Re: [PATCH] s390: cleanup timer API use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 24 Mar 2022 18:34:01 +0100
From:   Heiko Carstens <hca@...ux.ibm.com>
To:     Yu Liao <liaoyu15@...wei.com>
Cc:     gor@...ux.ibm.com, agordeev@...ux.ibm.com,
        linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org,
        liwei391@...wei.com
Subject: Re: [PATCH] s390: cleanup timer API use

On Tue, Mar 22, 2022 at 11:00:57AM +0800, Yu Liao wrote:
> cleanup the s390's use of the timer API
> - del_timer() contains timer_pending() condition
> - mod_timer(timer, expires) is equivalent to:
> 
> 	del_timer(timer);
> 	timer->expires = expires;
> 	add_timer(timer);
> 
> If the timer is inactive it will be activated, using add_timer() on
> condition !timer_pending(&private->timer) is redundant.
> 
> Just cleanup, no logic change.
> 
> Signed-off-by: Yu Liao <liaoyu15@...wei.com>
> ---
>  drivers/s390/char/sclp.c       |  4 +---
>  drivers/s390/char/sclp_con.c   |  3 +--
>  drivers/s390/char/sclp_vt220.c |  6 ++----
>  drivers/s390/cio/device_fsm.c  | 12 +++---------
>  drivers/s390/cio/eadm_sch.c    | 12 +++---------
>  5 files changed, 10 insertions(+), 27 deletions(-)

Applied, thanks.