lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 24 Mar 2022 20:03:37 +0200 From: Leon Romanovsky <leon@...nel.org> To: Randy Dunlap <rdunlap@...radead.org> Cc: linux-kernel@...r.kernel.org, "Michael S. Tsirkin" <mst@...hat.com>, Jason Wang <jasowang@...hat.com>, Paolo Bonzini <pbonzini@...hat.com>, Stefan Hajnoczi <stefanha@...hat.com>, Jens Axboe <axboe@...nel.dk>, Amit Shah <amit@...nel.org>, Arnd Bergmann <arnd@...db.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Eli Cohen <eli@...lanox.com>, Saeed Mahameed <saeedm@...dia.com>, Pablo Neira Ayuso <pablo@...filter.org>, Jozsef Kadlecsik <kadlec@...filter.org>, Florian Westphal <fw@...len.de>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, "James E.J. Bottomley" <jejb@...ux.ibm.com>, "Martin K. Petersen" <martin.petersen@...cle.com>, Felipe Balbi <felipe.balbi@...ux.intel.com>, Michał Mirosław <mirq-linux@...e.qmqm.pl>, Sebastian Andrzej Siewior <bigeasy@...utronix.de>, Krzysztof Opasiak <k.opasiak@...sung.com>, Igor Kotrasinski <i.kotrasinsk@...sung.com>, Valentina Manea <valentina.manea.m@...il.com>, Shuah Khan <shuah@...nel.org>, Shuah Khan <skhan@...uxfoundation.org>, Jussi Kivilinna <jussi.kivilinna@...et.fi>, Joachim Fritschi <jfritschi@...enet.de>, Herbert Xu <herbert@...dor.apana.org.au>, Thomas Gleixner <tglx@...utronix.de>, Steven Rostedt <rostedt@...dmis.org>, Ingo Molnar <mingo@...nel.org>, Karol Herbst <karolherbst@...il.com>, Pekka Paalanen <ppaalanen@...il.com>, Dave Hansen <dave.hansen@...ux.intel.com>, Andy Lutomirski <luto@...nel.org>, Peter Zijlstra <peterz@...radead.org>, Borislav Petkov <bp@...en8.de>, "H. Peter Anvin" <hpa@...or.com>, netfilter-devel@...r.kernel.org, coreteam@...filter.org, netdev@...r.kernel.org, linux-block@...r.kernel.org, linux-crypto@...r.kernel.org, linux-rdma@...r.kernel.org, linux-scsi@...r.kernel.org, linux-usb@...r.kernel.org, nouveau@...ts.freedesktop.org, virtualization@...ts.linux-foundation.org, x86@...nel.org Subject: Re: [PATCH 3/9] net: mlx5: eliminate anonymous module_init & module_exit On Wed, Mar 16, 2022 at 12:20:04PM -0700, Randy Dunlap wrote: > Eliminate anonymous module_init() and module_exit(), which can lead to > confusion or ambiguity when reading System.map, crashes/oops/bugs, > or an initcall_debug log. > > Give each of these init and exit functions unique driver-specific > names to eliminate the anonymous names. > > Example 1: (System.map) > ffffffff832fc78c t init > ffffffff832fc79e t init > ffffffff832fc8f8 t init > > Example 2: (initcall_debug log) > calling init+0x0/0x12 @ 1 > initcall init+0x0/0x12 returned 0 after 15 usecs > calling init+0x0/0x60 @ 1 > initcall init+0x0/0x60 returned 0 after 2 usecs > calling init+0x0/0x9a @ 1 > initcall init+0x0/0x9a returned 0 after 74 usecs > > Fixes: e126ba97dba9 ("mlx5: Add driver for Mellanox Connect-IB adapters") > Signed-off-by: Randy Dunlap <rdunlap@...radead.org> > Cc: Eli Cohen <eli@...lanox.com> > Cc: Saeed Mahameed <saeedm@...dia.com> > Cc: netdev@...r.kernel.org > Cc: Leon Romanovsky <leon@...nel.org> > Cc: linux-rdma@...r.kernel.org > --- > drivers/net/ethernet/mellanox/mlx5/core/main.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky <leonro@...dia.com>
Powered by blists - more mailing lists