linux-kernel - w1/ds2490: fix excessive logging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 24 Mar 2022 20:32:45 +0100
From:   Christian Vogel <vogelchr@...el.cx>
To:     greg@...ah.com, linux-kernel@...r.kernel.org
Cc:     zbr@...emap.net, vogelchr@...el.cx
Subject: w1/ds2490: fix excessive logging

As suggested by Greg, I've sorted the many pr_info calls in ds2490
that were used for rather eclectic logging into dev_info/dev_debug
instead of my first attempt of introducing a module parameter. Now
debugging should cease for the normal configurations without DEBUG.

Only the first two lines will show up, and the status will not be
extensively decoded/commented.

kern  :info  : [293529.095345] usb 2-1.3.1: Clearing ep0x83.
kern  :info  : [293529.097271] usb 2-1.3.1: ep_status=0x81,
        count=16, status=01:00:20:40:05:04:04:00:20:53:00:00:00:00:00:00
kern  :debug : [293529.097282] usb 2-1.3.1: enable flag: 0x01
kern  :debug : [293529.097286] usb 2-1.3.1: 1-wire speed: 0x00
kern  :debug : [293529.097290] usb 2-1.3.1: strong pullup duration: 0x20
kern  :debug : [293529.097293] usb 2-1.3.1: programming pulse duration: 0x40
kern  :debug : [293529.097297] usb 2-1.3.1: pulldown slew rate control: 0x05
kern  :debug : [293529.097300] usb 2-1.3.1: write-1 low time: 0x04
kern  :debug : [293529.097304] usb 2-1.3.1: data sample offset/write-0 recovery time: 0x04
kern  :debug : [293529.097308] usb 2-1.3.1: reserved (test register): 0x00
kern  :debug : [293529.097311] usb 2-1.3.1: device status flags: 0x20
kern  :debug : [293529.097315] usb 2-1.3.1: communication command byte 1: 0x53
kern  :debug : [293529.097318] usb 2-1.3.1: communication command byte 2: 0x00
kern  :debug : [293529.097322] usb 2-1.3.1: communication command buffer status: 0x00
kern  :debug : [293529.097325] usb 2-1.3.1: 1-wire data output buffer status: 0x00
kern  :debug : [293529.097329] usb 2-1.3.1: 1-wire data input buffer status: 0x00