linux-kernel - Re: [PATCH v2] PCI: dwc: Fix setting error return on MSI DMA mapping failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 24 Mar 2022 16:04:14 -0500
From:   Rob Herring <robh@...nel.org>
To:     Jiantao Zhang <water.zhangjiantao@...wei.com>
Cc:     Bjorn Helgaas <helgaas@...nel.org>,
        "jingoohan1@...il.com" <jingoohan1@...il.com>,
        "gustavo.pimentel@...opsys.com" <gustavo.pimentel@...opsys.com>,
        "lorenzo.pieralisi@....com" <lorenzo.pieralisi@....com>,
        "kw@...ux.com" <kw@...ux.com>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "zhangjianrong (E)" <zhangjianrong5@...wei.com>,
        caiyadong <caiyadong@...wei.com>,
        "xuetao (kirin)" <xuetao09@...wei.com>,
        xuhaiyang <xuhaiyang5@...ilicon.com>, songxiaowei@...ilicon.com,
        guhengsheng@...ilicon.com
Subject: Re: [PATCH v2] PCI: dwc: Fix setting error return on MSI DMA mapping
 failure

On Wed, Mar 09, 2022 at 08:01:04PM +0800, Jiantao Zhang wrote:
> When dma_mapping_error() returns error because of no enough memory,
> but dw_pcie_host_init() returns success, which will mislead the callers.
> 
> Fixes: 07940c369a6b ("PCI: dwc: Fix MSI page leakage in suspend/resume")
> Signed-off-by: Jianrong Zhang <zhangjianrong5@...wei.com>
> Signed-off-by: Jiantao Zhang <water.zhangjiantao@...wei.com>
> ---
>   drivers/pci/controller/dwc/pcie-designware-host.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Rob Herring <robh@...nel.org>