linux-kernel - Re: [PATCH] Documentation: Fix duplicate statement about raw_spinlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87r16peslf.fsf@meer.lwn.net>
Date:   Fri, 25 Mar 2022 13:32:12 -0600
From:   Jonathan Corbet <corbet@....net>
To:     "Guilherme G. Piccoli" <gpiccoli@...lia.com>,
        linux-doc@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, gpiccoli@...lia.com,
        kernel@...ccoli.net, Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] Documentation: Fix duplicate statement about
 raw_spinlock_t type

"Guilherme G. Piccoli" <gpiccoli@...lia.com> writes:

> Unless it was duplicate on purpose, to emphasize that a raw_spinlock_t
> is always a spinning lock regardless of PREEMPT_RT or kernel config,
> it's a bit odd that this text is duplicate. So, this patch just clean
> it up, keeping the consistency with the other sections of the text.
>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Fixes: 919e9e6395cf ("Documentation: Add lock ordering and nesting documentation")
> Signed-off-by: Guilherme G. Piccoli <gpiccoli@...lia.com>
> ---
>  Documentation/locking/locktypes.rst | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/Documentation/locking/locktypes.rst b/Documentation/locking/locktypes.rst
> index bfa75ea1b66a..9933faad4771 100644
> --- a/Documentation/locking/locktypes.rst
> +++ b/Documentation/locking/locktypes.rst
> @@ -211,9 +211,6 @@ raw_spinlock_t and spinlock_t
>  raw_spinlock_t
>  --------------
>  
> -raw_spinlock_t is a strict spinning lock implementation regardless of the
> -kernel configuration including PREEMPT_RT enabled kernels.
> -
>  raw_spinlock_t is a strict spinning lock implementation in all kernels,
>  including PREEMPT_RT kernels.  Use raw_spinlock_t only in real critical
>  core code, low-level interrupt handling and places where disabling

I don't think that was intentional.  Applied, thanks.

For future reference, a far better changelog would have been something
like:

	Remove the duplicated sentence from locktypes.rst

Thanks,

jon