linux-kernel - Re: [PATCH] arm64: dts: qcom: sc7180-trogdor: Simply SAR sensor enabling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 25 Mar 2022 14:21:16 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Stephen Boyd <swboyd@...omium.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: qcom: sc7180-trogdor: Simply SAR sensor enabling

Hi,

On Fri, Mar 25, 2022 at 2:16 PM Stephen Boyd <swboyd@...omium.org> wrote:
>
> The SAR node, ap_sar_sensor, needs to be enabled in addition to the i2c
> bus it resides on. Let's simplify this by leaving the sensor node
> enabled by default while leaving the i2c bus disabled by default. On
> boards that use the sensor, we already enable the i2c bus so we can
> simply remove the extra bit that enables the sar sensor node. This saves
> some lines but is otherwise a non-functional change.
>
> Cc: Douglas Anderson <dianders@...omium.org>
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>
> ---
>  arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-lte.dts | 4 ----
>  arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dts | 4 ----
>  arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-lte.dts | 4 ----
>  arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi             | 1 -
>  4 files changed, 13 deletions(-)

Makes sense to me and even saves a byte or two.

Reviewed-by: Douglas Anderson <dianders@...omium.org>

-Doug