linux-kernel - Re: [PATCH v1] crypto: stm32: Check for NULL return of kmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 25 Mar 2022 16:16:19 +1200
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     QintaoShen <unSimple1993@....com>
Cc:     davem@...emloft.net, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org, unSimple1993@....com
Subject: Re: [PATCH v1] crypto: stm32: Check for NULL return of
 kmalloc_array()

QintaoShen <unSimple1993@....com> wrote:
> As the potential failure of memory allocation, kmalloc_array() may return
> NULL and lead to NULL pointer dereference because of the usage of 'rctx->hw_context'.
> 
> Therefore, it is better to check the return value of kmalloc_array().
> 
> Signed-off-by: QintaoShen <unSimple1993@....com>
> ---
> drivers/crypto/stm32/stm32-hash.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/crypto/stm32/stm32-hash.c b/drivers/crypto/stm32/stm32-hash.c
> index d33006d..f1a1a13 100644
> --- a/drivers/crypto/stm32/stm32-hash.c
> +++ b/drivers/crypto/stm32/stm32-hash.c
> @@ -970,7 +970,8 @@ static int stm32_hash_export(struct ahash_request *req, void *out)
>        rctx->hw_context = kmalloc_array(3 + HASH_CSR_REGISTER_NUMBER,
>                                         sizeof(u32),
>                                         GFP_KERNEL);
> -
> +       if (!rctx->hw_context)
> +               return -ENOMEM;

This patch introduces a runtime PM imbalance.  Please fix.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt