linux-kernel - RE: [PATCH 2/2] i2c:aspeed:support ast2600 i2c new register mode driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <HK0PR06MB3380636B12959660E04403CDF21A9@HK0PR06MB3380.apcprd06.prod.outlook.com>
Date:   Fri, 25 Mar 2022 05:19:29 +0000
From:   Ryan Chen <ryan_chen@...eedtech.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     BMC-SW <BMC-SW@...eedtech.com>, Rob Herring <robh+dt@...nel.org>,
        Joel Stanley <joel@....id.au>,
        Andrew Jeffery <andrew@...id.au>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2/2] i2c:aspeed:support ast2600 i2c new register mode
 driver

Hello,
> -----Original Message-----
> From: Andrew Lunn <andrew@...n.ch>
> Sent: Wednesday, March 23, 2022 8:38 PM
> To: Ryan Chen <ryan_chen@...eedtech.com>
> Cc: BMC-SW <BMC-SW@...eedtech.com>; Rob Herring
> <robh+dt@...nel.org>; Joel Stanley <joel@....id.au>; Andrew Jeffery
> <andrew@...id.au>; Philipp Zabel <p.zabel@...gutronix.de>;
> linux-arm-kernel@...ts.infradead.org; linux-aspeed@...ts.ozlabs.org;
> linux-kernel@...r.kernel.org
> Subject: Re: [PATCH 2/2] i2c:aspeed:support ast2600 i2c new register mode
> driver
> 
> On Wed, Mar 23, 2022 at 08:40:09AM +0800, ryan_chen wrote:
> > Add i2c new register mode driver to support AST2600 i2c new register
> > set. AST2600 i2c controller have legacy and new register mode. The new
> > register mode have global register support 4 base clock for scl clock
> > selection, and new clock divider mode. And i2c new register mode have
> > separate register set to control i2c master and slave.
> >
> > Signed-off-by: Ryan Chen <ryan_chen@...eedtech.com>
> > ---
> >  drivers/i2c/busses/Kconfig                 |   11 +
> >  drivers/i2c/busses/Makefile                |    1 +
> >  drivers/i2c/busses/aspeed-i2c-new-global.c |   91 ++
> >  drivers/i2c/busses/aspeed-i2c-new-global.h |   19 +
> >  drivers/i2c/busses/i2c-new-aspeed.c        | 1698
> ++++++++++++++++++++
> 
> I always find it funny when somebody uses 'new'. What is the next version
> going to be called? 'even-newer', and the version after that 'really-really-new'?
> 
> > +static const struct of_device_id aspeed_new_i2c_bus_of_table[] = {
> > +	{
> > +		.compatible = "aspeed,ast2600-i2c-bus",
> > +	},
> 
> Given this compatible string, why not call it i2c-aspeed-2600.c, and remove
> 'new' everywhere.
> 
Yes, I struggle the naming, but the next generation ast2700 still used.
The name "i2c-aspeed-2600.c" may not adaptable. 
Or How about name it to i2c-aspeed-package.c due to this is major feature
For this new i2c controller design?

Ryan