linux-kernel - Re: [PATCH] exfat: reduce block requests when zeroing a cluster

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yj1wZtQId8QVtBop@infradead.org>
Date:   Fri, 25 Mar 2022 00:33:58 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     "Yuezhang.Mo@...y.com" <Yuezhang.Mo@...y.com>
Cc:     Christoph Hellwig <hch@...radead.org>,
        Namjae Jeon <linkinjeon@...nel.org>,
        "sj1557.seo@...sung.com" <sj1557.seo@...sung.com>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Andy.Wu@...y.com" <Andy.Wu@...y.com>,
        "Wataru.Aoyama@...y.com" <Wataru.Aoyama@...y.com>
Subject: Re: [PATCH] exfat: reduce block requests when zeroing a cluster

On Fri, Mar 25, 2022 at 07:22:54AM +0000, Yuezhang.Mo@...y.com wrote:
> Hi Christoph Hellwig,
> 
> Thank you for your comment.
> 
> > On Fri, Mar 25, 2022 at 03:00:55AM +0000, Yuezhang.Mo@...y.com wrote:
> > > +#include <linux/blk_types.h>
> > 
> > blk_types.h is not a header for public use.  What do you want it for?
> 
> +	struct address_space *mapping = sb->s_bdev->bd_inode->i_mapping;
> 
> The type of 'sb->s_bdev' is 'struct block_device'.
> I want to include the definition of 'struct block_device'('struct block_device' is defined in <linux/blk_types.h>).

Oh, I missed that.  We really should not derefrence bd_inode in file
systems.  So maybe we need to add a sync_blockdev_range abstraction if
we want to support this use case.