| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 25 Mar 2022 14:36:27 +0100
From: Johannes Holland <johannes.holland@...ineon.com>
To: <peterhuewe@....de>, <jarkko@...nel.org>, <jgg@...pe.ca>,
<linux-kernel@...r.kernel.org>, <linux-integrity@...r.kernel.org>
CC: Johannes Holland <johannes.holland@...ineon.com>,
kernel test robot <lkp@...el.com>
Subject: [PATCH v2] tpm: Fix regression in tpm_tis_synquacer.c
Remove unused variables and type mismatch (integer from pointer without
a cast).
Reported-by: kernel test robot <lkp@...el.com>
Fixes: a536629ef32d ("tpm: Remove read16/read32/write32 calls from tpm_tis_phy_ops")
Signed-off-by: Johannes Holland <johannes.holland@...ineon.com>
---
Like v1, this applies to Jarkko's master branch. If you need me to
rebase to another branch, please let me know.
Sorry for the inconvenience!
sparse warnings: (new ones prefixed by >>)
drivers/char/tpm/tpm_tis_synquacer.c:89:32: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned char [usertype] value @@ got unsigned char const [usertype] * @@
drivers/char/tpm/tpm_tis_synquacer.c:89:32: sparse: expected unsigned char [usertype] value
drivers/char/tpm/tpm_tis_synquacer.c:89:32: sparse: got unsigned char const [usertype] *
drivers/char/tpm/tpm_tis_synquacer.c:90:32: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned char [usertype] value @@ got unsigned char const [usertype] * @@
drivers/char/tpm/tpm_tis_synquacer.c:90:32: sparse: expected unsigned char [usertype] value
drivers/char/tpm/tpm_tis_synquacer.c:90:32: sparse: got unsigned char const [usertype] *
drivers/char/tpm/tpm_tis_synquacer.c:91:32: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned char [usertype] value @@ got unsigned char const [usertype] * @@
drivers/char/tpm/tpm_tis_synquacer.c:91:32: sparse: expected unsigned char [usertype] value
drivers/char/tpm/tpm_tis_synquacer.c:91:32: sparse: got unsigned char const [usertype] *
drivers/char/tpm/tpm_tis_synquacer.c:92:32: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned char [usertype] value @@ got unsigned char const [usertype] * @@
drivers/char/tpm/tpm_tis_synquacer.c:92:32: sparse: expected unsigned char [usertype] value
drivers/char/tpm/tpm_tis_synquacer.c:92:32: sparse: got unsigned char const [usertype] *
drivers/char/tpm/tpm_tis_synquacer.c:89:33: sparse: sparse: non size-preserving pointer to integer cast
drivers/char/tpm/tpm_tis_synquacer.c:90:33: sparse: sparse: non size-preserving pointer to integer cast
drivers/char/tpm/tpm_tis_synquacer.c:91:33: sparse: sparse: non size-preserving pointer to integer cast
drivers/char/tpm/tpm_tis_synquacer.c:92:33: sparse: sparse: non size-preserving pointer to integer cast
drivers/char/tpm/tpm_tis_synquacer.c | 18 ++++--------------
1 file changed, 4 insertions(+), 14 deletions(-)
diff --git a/drivers/char/tpm/tpm_tis_synquacer.c b/drivers/char/tpm/tpm_tis_synquacer.c
index 2751be8e6065..679196c61401 100644
--- a/drivers/char/tpm/tpm_tis_synquacer.c
+++ b/drivers/char/tpm/tpm_tis_synquacer.c
@@ -39,11 +39,6 @@ static int tpm_tis_synquacer_read_bytes(struct tpm_tis_data *data, u32 addr,
enum tpm_tis_io_mode io_mode)
{
struct tpm_tis_synquacer_phy *phy = to_tpm_tis_tcg_phy(data);
- __le16 result_le16;
- __le32 result_le32;
- u16 result16;
- u32 result32;
-
switch (io_mode) {
case TPM_TIS_PHYS_8:
while (len--)
@@ -69,11 +64,6 @@ static int tpm_tis_synquacer_write_bytes(struct tpm_tis_data *data, u32 addr,
enum tpm_tis_io_mode io_mode)
{
struct tpm_tis_synquacer_phy *phy = to_tpm_tis_tcg_phy(data);
- __le16 result_le16;
- __le32 result_le32;
- u16 result16;
- u32 result32;
-
switch (io_mode) {
case TPM_TIS_PHYS_8:
while (len--)
@@ -86,10 +76,10 @@ static int tpm_tis_synquacer_write_bytes(struct tpm_tis_data *data, u32 addr,
* Due to the limitation of SPI controller on SynQuacer,
* 16/32 bits access must be done in byte-wise and descending order.
*/
- iowrite8(&value[3], phy->iobase + addr + 3);
- iowrite8(&value[2], phy->iobase + addr + 2);
- iowrite8(&value[1], phy->iobase + addr + 1);
- iowrite8(&value[0], phy->iobase + addr);
+ iowrite8(value[3], phy->iobase + addr + 3);
+ iowrite8(value[2], phy->iobase + addr + 2);
+ iowrite8(value[1], phy->iobase + addr + 1);
+ iowrite8(value[0], phy->iobase + addr);
break;
}
--
2.31.1.windows.1
Powered by blists - more mailing lists