linux-kernel - Re: [PATCH] SUNRPC: Increase size of servername string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <164817399413.6096.7103093569920914714@noble.neil.brown.name>
Date:   Fri, 25 Mar 2022 13:06:34 +1100
From:   "NeilBrown" <neilb@...e.de>
To:     "Haowen Bai" <baihaowen@...zu.com>
Cc:     trond.myklebust@...merspace.com, anna@...nel.org,
        chuck.lever@...cle.com, davem@...emloft.net, kuba@...nel.org,
        pabeni@...hat.com, linux-nfs@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        "Haowen Bai" <baihaowen@...zu.com>
Subject: Re: [PATCH] SUNRPC: Increase size of servername string

On Thu, 24 Mar 2022, Haowen Bai wrote:
> This patch will fix the warning from smatch:
> 
> net/sunrpc/clnt.c:562 rpc_create() error: snprintf() chops off
> the last chars of 'sun->sun_path': 108 vs 48
> 
> Signed-off-by: Haowen Bai <baihaowen@...zu.com>
> ---
>  net/sunrpc/clnt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
> index c83fe61..6e0209e 100644
> --- a/net/sunrpc/clnt.c
> +++ b/net/sunrpc/clnt.c
> @@ -526,7 +526,7 @@ struct rpc_clnt *rpc_create(struct rpc_create_args *args)
>  		.servername = args->servername,
>  		.bc_xprt = args->bc_xprt,
>  	};
> -	char servername[48];
> +	char servername[108];

It would be much nicer to use UNIX_PATH_MAX

NeilBrown


>  	struct rpc_clnt *clnt;
>  	int i;
>  
> -- 
> 2.7.4
> 
>